Repository navigation
Conversation
Owner
|
Is there a reason why it's a seperate repo? |
Flake Review Results for #204Available systems: aarch64-darwin, aarch64-linux, armv6l-linux, armv7l-linux, i686-linux, powerpc64le-linux, riscv64-linux, x86_64-freebsd, x86_64-linux 🔄 Modified (2)
Generated by flake-review |
Contributor
Author
|
Mainly to keep them independent: TidalEQ needs mpv, is Windows-only for now and has its own releases, issues and changelog, so updating one doesn't force a new release of the other. That said, if you'd rather keep one store entry per author, I'm happy to publish both from a single store repo instead. Just let me know which you prefer. |
Owner
|
Generally speaking Luna's plugin ecosystem is structured around the idea of one store per author. It also means you don't need to PR every time you add a new plugin. I'd rather have them combined into a single monorepo containing all your plugins. Will close this for now, you can open a new PR to add the monorepo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TidalEqualizer to the default community stores, right below TidalPresence (#203).
TidalEQ adds Equalizer and Visualizer tabs to TIDAL's now-playing view, next to Similar tracks, Credits and Lyrics:
How it works: TIDAL plays audio in its native player, which plugins can't reach, so TidalEQ plays tracks through mpv with an FFmpeg filter chain. TIDAL's own player keeps running muted, so progress, queue, seeking and volume work as usual. Videos are left to TIDAL. If mpv is missing or stops, TidalEQ says so and TIDAL plays normally.
Notes for users:
Store URL:
https://github.com/BaeHyolyn/TidalEqualizer/releases/latest/download/store.json(current release v1.4.1, built and published by CI on each tag).Also bumps the version to 1.19.0-beta, as in #203.