Repository navigation
melodi - #306
melodi#306
Conversation
|
@hadrilec @linogaliana @tfardet @RLesur do any of you guys see the point in covering MELODI's "référentiel" endpoint through It doesn't seem to be used in the R package and I have no usecase in my mind right now (that and the fact that the json returned seem overly complex to be used in a generic way)... |
|
Note: 2 tickets have been opened on INSEE's API portal.
|
|
Hi, I had started in the branch catalog to write a function retrieving the list of datasets available via melodi. On the long term, I think it makes sense, as I understand more INSEE datasets shall be available melodi. I understand that DoReMiFaSol already uses melodi: https://github.com/InseeFrLab/DoReMIFaSol |
|
Hi @hadrilec , I've already re-used your code for the catalog (which I also think is gonna be madatory). I was instead speaking of the "référentiel" endpoint and I haven't quite seen the point (yet ?). Right now, you got catalog (as already said), you got all available dimensions and values for a given dataset using the "range" endpoint : it seems to me that's enough ? |
* add .vscode to gitignore * add notebooks to gitignore * wip docstrings and fixes data.py * fix measures column issue in _parse_dataset_observations * fix(melodi): handle non-MELODI idbanks * test(melodi): add pytest coverage and fix update/silent signatures Signed-off-by: GrasClement <gras.clement@orange.fr> * test(melodi): finish tests for melodi Signed-off-by: GrasClement <gras.clement@orange.fr> * doc(melodi): add melodi to the documentation Signed-off-by: GrasClement <gras.clement@orange.fr> * doc(melodi): linting Signed-off-by: GrasClement <gras.clement@orange.fr> * doc(melodi): fix spacing Signed-off-by: GrasClement <gras.clement@orange.fr> * fix(melodi): simplify measures parsing, log empty idbank results Signed-off-by: GrasClement <gras.clement@orange.fr> * test(melodi): fix redundant checks and update comments per review Signed-off-by: GrasClement <gras.clement@orange.fr> * doc(melodi): reorder modules and flag metadata as deprecated Signed-off-by: GrasClement <gras.clement@orange.fr> --------- Signed-off-by: GrasClement <gras.clement@orange.fr> Co-authored-by: cgras <clement.gras@ccomptes.fr>
|
This should be ok, let's review @tfardet when you got time enough ! |
tfardet
left a comment
There was a problem hiding this comment.
Thanks @tgrandje and @GrasClement for this new additions.
I have a few points of discussions that I opened regarding naming and descriptions, let me know what you think.
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
|
Just spotted that Melodi isn't in the sources listed in the "Data Search and Collection Advice" section of root README.md yet, might want to add it rightaway ? |
|
@GrasClement thanks, I had completly forgotten about that : I've altered it, please have a look. @GrasClement @tfardet feel free to complete/correct this PR without me, I'll be unavailable for the next 10-ish days. |
|
@GrasClement yes, if you can make a PR against this branch with these two things I can include it and merge everything, thanks! |
* add Melodi to README.md, rollback to 3.10 in toml and minor dosctring wording change * also mention get_series in README --------- Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
|
Failing tests are unrelated, so merging as is |
No description provided.