Skip to content

Prepare for 2.4.0 release - #392

Merged
vlad-perevezentsev merged 3 commits into
masterfrom
prepare-for-2.4.0-release
Oct 16, 2026
Merged

vlad-perevezentsev merged 3 commits into
masterfrom
prepare-for-2.4.0-release

Conversation

@vlad-perevezentsev

Copy link
Copy Markdown
Collaborator

The PR updates __version__ and CHANGELOG.md to publish the new 2.4.0 release

@antonwolfy antonwolfy added this to the 2.4.0 release milestone Oct 15, 2026

@jharlow-intel jharlow-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump and changelog look right and match the 2.3.0 release PR (#349); the new #382 and #389 entries match the merged code.

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the version bump and the final 2.4.0 changelog against the code merged in this cycle. The version bump looks good. My comments are inline, plus two on lines outside the diff:

  • CHANGELOG.md:11 (Python 3.15): mkl-service has no cp315 wheel and no sdist on PyPI yet (2.8.0 ships cp310–cp314 only). So on 3.15, pip install "mkl_fft[scipy_interface]" and pip install "mkl_fft[test]" fail to resolve. Both clang workflows already leave out 3.15 for this reason (see the TODO there). I'd add a short note about this to the entry.
  • CHANGELOG.md:27-28 (gh-364, gh-365): both only silence Coverity reports and change nothing at runtime. One declares cdef int f_ndim, the other adds (void)status for an assert that is compiled out under -DNDEBUG. Under "Fixed" they read as if 2.3.x had real bugs in _allocate_result and __create_descriptor_1d. I'd drop them, same as the gh-374 entry.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the refined entries address my comments. The new wording matches the merged code.

@vlad-perevezentsev
vlad-perevezentsev merged commit cdafe6e into master Oct 16, 2026
111 of 123 checks passed
@vlad-perevezentsev
vlad-perevezentsev deleted the prepare-for-2.4.0-release branch October 16, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants