Repository navigation
Add update-pr skill for publishing staged changes - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Publishing follow-up changes to an existing PR requires staging and committing local changes, pushing them to the correct branch, and keeping the PR description accurate. The existing
create-prskill covers initial PR creation, but not this recurring workflow. Add a dedicated skill so these steps can be requested together without creating a duplicate PR, while honoring explicit limits on which changes to publish.Design Decision
Separate creation from updates
Keep
update-prfocused on existing open PRs and reusecreate-pr's Git safety rules, confidentiality rules, and GitHub tooling policy. This keeps the two workflows distinct without introducing a script or duplicating their shared policies.Use the right scope for each operation
By default, review both staged and unstaged changes, then stage tracked changes with
git add -u, including the remaining edits in partially staged files. Honor staged-only or narrower requests and leave untracked files untouched unless explicitly included. Use the reviewed staged diff as the source of truth for the new commit and the full published PR diff for its description. Cymbal provides optional change-impact context, but does not determine what gets committed or published.Share the description format within the Pi package
Move the existing description template and writing rules into
skills/references/pr-description.md, which both PR skills read directly. These skills are intended for use together in this Pi package, so a package-local shared reference avoids template drift without duplicating files or adding a generation step. Keep creation-specific behavior, including the Draft default, increate-pr.Summary
update-prskill covering target verification, staging tracked changes, commits, explicit pushes, whole-PR description updates, and partial-failure reporting./skill:update-pr, its requirements, and bundled shared skill references in the README.