feat: a form opens in the jContent Page Builder from the Content Folders - #232
Draft
hduchesne wants to merge 13 commits into
Draft
feat: a form opens in the jContent Page Builder from the Content Folders#232hduchesne wants to merge 13 commits into
hduchesne wants to merge 13 commits into
Conversation
hduchesne
added a commit
that referenced
this pull request
Aug 28, 2026
Contributor
📝 Documentation GuidelinesThank you for contributing to our documentation! To ensure your contributions meet our standards, please review these resources:
This comment is posted automatically when changes are detected in the |
hduchesne
added a commit
that referenced
this pull request
Aug 28, 2026
hduchesne
force-pushed
the
feat/pagebuilder-form-editing-v2
branch
from
August 28, 2026 15:20
9019d4e to
a780cc8
Compare
fmdb:form carries jmix:mainResource (the Page Builder view mode is offered to pages and main resources only) and gets a template of its own — a minimal layout rendering the new fullPage view, priority 1 over a template set's generic main-resource template — so a form can be authored where it renders without a page around it. The authoring model is the one of #230 (flat steps, one box per node, typed create buttons, coloured levels). Spec 80 opens a form from the Content Folders, checks the create buttons of the field list and the stacked steps; docs/pagebuilder-form-editing.md describes the whole model. Supersedes the July branch feat/pagebuilder-form-editing (its placement-scope mixin chain is dropped: typed, labelled buttons made it pointless).
On its own page nothing sits above the form, so the Page Builder drew the field list's bar over the first field. Edit mode only.
A light page, a white sheet 80% wide (capped at 60rem) with the form inside, live and edit alike; every value is a variable and a template set overrides the fullPage view for a page of its own. The sheet's top padding replaces the edit-only room added for the Page Builder bar.
Like a site page: the title on top, the form below, centred at 80%. The card look stays one variable away.
The fullPage view re-rendered the form node, giving the Page Builder two modules for one path, and the title sat in the layout, outside the form's module: nothing to click to reach the form. The view now renders the title, then the default view read-only: one box for the form, and clicking its title opens Edit on the form (title, intro, buttons, responses).
… stays plain hidden.page carries what the standalone page needs (title inside the form's box, read-only inner render, page-specific classes); fullPage goes back to being the default view under a distinct name, free for template sets.
… clickable strip jContent already shows the title above the Page Builder; the padding of the hidden.page wrapper is what a contributor clicks to select the form.
No wrapper, no padding: the form is edited through jContent's Edit button, the form being the current node. Read-only stays, so the Page Builder gets one module for the form node instead of two nested boxes.
…0% column The view the form page template renders is named after its purpose. The page keeps the form full width with Moonstone's large spacing around it (--spacing-large, resolved in the Page Builder iframe, 24px fallback in live).
hduchesne
force-pushed
the
feat/pagebuilder-form-editing-v2
branch
from
August 28, 2026 16:15
e20e31c to
c41ec85
Compare
Contributor
🦜 Chachalog
|
Redundant with hidden.pageBuilder, which the form page template renders; it only mirrored the sample template set's convention and was never used.
…thoring Without an intro the form and its field list started at the same pixel, so the form's own box could not be reached. Edit mode only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #230. A form can now be opened in the jContent Page Builder directly from the Content Folders, without a page around it:
fmdb:formcarriesjmix:mainResource— jContent offers the Page Builder view mode to pages and main resources only.fmdb:form(templates/Form, priority 1 over a template set's generic main-resource template) renders the newfullPageview through a minimal layout. Side effect: a form is also reachable in live at its own URL.The authoring model is the one of #230 (flat steps, one box per node, typed create buttons, coloured levels);
docs/pagebuilder-form-editing.mddescribes the whole. Spec 80 (newpagebuilder/folder) opens a form from the Content Folders, checks the field list's create buttons and the stacked steps.Supersedes the July branch
feat/pagebuilder-form-editing: its placement-scope mixin chain is dropped, typed and labelled buttons made it pointless. jContent issue #2627 (two stacked boxes) was on our side and is closed.Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review