fix: state each server settings screen's permission requirement on the screen itself (9.10 backport) - #241
Draft
baptistegrimaud wants to merge 1 commit into
Conversation
…e screen itself Backport of #234 onto the 9_10_x line. The About and system information screens each declare, next to their own default view, the permission they require. Stating it on the view rather than on the settings template that normally hosts them means the requirement travels with the screen and holds on every render path. Both permissions the properties name are already defined on this line, in src/main/import/permissions.xml. The changelog entry from #234 is left out: this line has no .chachalog directory and none of its tooling reads one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #234 onto the
9_10_xline.Based on #240, not on
9_10_xdirectly. That PR opens the line for development on9.10.1-SNAPSHOTand makes it publishable; this one is stacked on it so the change lands on a line that can actually ship. Merge #240 first, and this PR's base then needs retargeting to9_10_x.What differs from #234
One thing. The changelog entry is left out. This line has no
.chachalogdirectory and none of its tooling reads one, which is also how9_7_xstands.The rest is identical to what merged on
main: both view.propertiesfiles and the Cypress spec, applied without conflict.Checked on this line rather than assumed
src/main/import/permissions.xml.@jahia/cypress. This line pins^3.35.0wheremainis on^8.2.1, so they were checked against 3.35.0 itself rather than against the version installed in a working copy: all six are present, and their signatures match the calls the spec makes.Not verified here
The suite has not been run against a deployed 9.10 instance. CI on this branch is the first execution.