Skip to content

docs: curses-unavailable fallback prints a warning, is not silent - #40

Merged
JarbasAl merged 1 commit into
devfrom
docs/fix-silently-aliased-claim
Sep 7, 2026
Merged

JarbasAl merged 1 commit into
devfrom
docs/fix-silently-aliased-claim

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Sonnet 5 (claude-sonnet-5) via Claude Code — NOT human-reviewed. Verify before acting.

docs/configuration.md said the JarbasCursesTerminal to JarbasCliTerminal fallback (when curses isn't importable) happens "silently." It doesn't: hivemind_cli_terminal/init.py prints "WARNING: curses interface not available" at import time in that branch. docs/troubleshooting.md already documents this correctly - this fixes the one inconsistent file to match it.

Verified claim: the print() call in the except ImportError branch, hivemind_cli_terminal/init.py on origin/dev.

Docs-only change, no code touched.

configuration.md said JarbasCursesTerminal is 'silently aliased' to
JarbasCliTerminal when curses can't be imported. hivemind_cli_terminal/__init__.py
prints 'WARNING: curses interface not available' at import time in that case
(confirmed on origin/dev) - troubleshooting.md already documents this correctly,
this was the one inconsistent file.
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Reporting for duty! The automated checks have completed. 🎖️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

I've finished my task! Here's the data you need. 📊

❌ ruff: issues found — see job log

⚖️ License Check

I've audited the 'About' files for accuracy. 📄

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🏷️ Release Preview

Drafting the announcement for your new feature! 📣

Current: 1.0.1a1 → Next: 1.0.1a2

Signal Value
Label (none)
PR title docs: curses-unavailable fallback prints a warning, is not silent
Bump alpha

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 1.0.1a2

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ⚪ Not in channel -
Alpha ⚪ Not in channel -

🔒 Security (pip-audit)

Checking for any potential privacy concerns. 🕶️

✅ No known vulnerabilities found (73 packages scanned).

📋 Repo Health

I've checked the repo's strength (aka test suite robustness). 🏋️‍♂️

✅ All required files present.

Latest Version: 1.0.1a1

✅ hivemind_cli_terminal/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ hivemind_cli_terminal/version.py has valid version block markers

📊 Coverage

Checking the insulation of our logic. 🏠

❌ 27.5% total coverage

Per-file coverage (3 files)
File Coverage Missing lines
hivemind_cli_terminal/__main__.py 0.0% 40
hivemind_cli_terminal/version.py 0.0% 5
hivemind_cli_terminal/__init__.py 46.9% 34

Full report: download the coverage-report artifact.

🔨 Build Tests

Structural analysis of your contribution is complete. 🔬

✅ All versions pass

Python Build Install Tests
3.10 ✅ ✅ ✅
3.11 ✅ ✅ ✅
3.12 ✅ ✅ ✅
3.13 ✅ ✅ ✅

Thanks for making OVOS better today! 🙌

@JarbasAl
JarbasAl marked this pull request as ready for review September 7, 2026 16:20
@JarbasAl
JarbasAl merged commit 80c413b into dev Sep 7, 2026
12 checks passed
@JarbasAl
JarbasAl deleted the docs/fix-silently-aliased-claim branch September 7, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant