Repository navigation
chore: untrack .tool-versions and ignore version manager files - #114
Merged
Merged
Conversation
The file pinned python 3.11.0 for asdf/mise, but nothing in the repo uses either tool: the CI matrix tests 3.10-3.13 and pyproject declares requires-python = ">=3.10". It was also being picked up into the sdist. It had already been removed once (830ae3b) and came back unintentionally with #99, so add .tool-versions, .python-version and .nvmrc to .gitignore to keep local version manager pins out of the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
python/.tool-versionspinnedpython 3.11.0for asdf/mise, but that pin doesn't describe this project:pyproject.tomldeclaresrequires-python = ">=3.10"— so a single-version pin is misleading.dist/flightradarapi-1.5.1/.tool-versions).It had already been removed once in 830ae3b ("remove useless config file") and came back unintentionally with #99.
Changes
python/.tool-versionsfrom version control..tool-versions,.python-versionand.nvmrcto.gitignore, so local version manager pins stay local. Since the repo is multi-language, the Node side is covered too.No effect on packaging, CI or runtime behavior — the file was never read by anything in the project.
🤖 Generated with Claude Code