Repository navigation
CI template: check a parity repository out outside the clone (#48) - #49
Merged
Merged
Conversation
The template's commented parity example checked the other repository out inside the clone: an untracked, un-ignored path that made `check.sh --changed` run the whole list on every pull request. The example now moves the checkout under the runner's temporary directory before any check runs and points the variable there. The selection report names an unmapped untracked path as such and says that a workflow-created path belongs outside the clone or in .gitignore; tracked unmapped paths keep the plain reason. The vendored scripts/dev/changed_checks.py stays the library code but for line 2. docs/adopting.md says the same in step 4, the worked example and the changed-path selection section. Closes #48 Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Narrow review: devkit #49 (issue #48) and #50 (issue #46)#49 (e779849 on 250b07a): the parity example now moves its checkout out of the clone before any check runs, and an unmapped untracked path gets its own reason; no findings. #49 dispositions
#50 dispositions
What I ran
#49 merge: ready, no HIGH, no MEDIUM, no LOW. |
|
🎉 Thank you for your contribution to Judgment Pack! If you’d like another task, choose a path that interests you: |
Merged
kikashy
added a commit
that referenced
this pull request
Oct 26, 2026
Version 0.9.0 in lib/common.sh and on line 2 of the vendored scripts and the template; the release notes for v0.9.0 (#49 workflow-created paths and --changed, #50 test suites and standard input). Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48: the CI template's commented parity example checked the other repository out inside the clone, an untracked, un-ignored path, so
check.sh --changedran the whole list on every pull request.What changes
templates/ci-check.yml: the commented parity example still uses the pinnedactions/checkout(which places a checkout only under the workspace), then a step moves it to${{ runner.temp }}/desk-checkoutbefore any check runs and pointsJPDEV_DESKthere. The comment says why the checkout must end up outside the clone. actionlint passes on the example uncommented.lib/changed_checks.pyand the vendoredscripts/dev/changed_checks.py(identical but for line 2): an unmapped path that onlygit ls-files --othersnames is reported asuntracked path PATH is not mapped; a workflow-created path belongs outside the clone or in .gitignore: whole list; a tracked unmapped path keepsunmapped path PATH: whole list. Selection is unchanged.docs/adopting.md: step 4, the worked example and "Changed-path check selection" say that any untracked, un-ignored path a workflow creates inside the clone defeats--changedand must live outside the clone or be ignored, and quote the report line.tests/changed_checks_test.py: the report text for an untracked unmapped path next to a tracked one, an ignored workflow path that leaves the selection scoped, and the existing untracked case updated; each runs through bothjpdev checkand the vendoredcheck.sh. Thetests/run.shcomparison of the two selection files passes unchanged.Mutant: reporting every unmapped path with the plain reason fails 4 tests (both new-text tests, through both runners).
Public surface
The selection report's whole-list reason for an unmapped untracked path (new text); the commented example in
templates/ci-check.yml; docs.Checks
Sign-off
Every commit carries a Developer Certificate of Origin sign-off that matches its author.
🤖 Generated with Claude Code