Repository navigation
Gate local manual Pack jobs on anchored Policy admission - #161
Conversation
Signed-off-by: kikashy <kikashy@hotmail.com> Co-authored-by: Codex (gpt-6.1-sol) <noreply@openai.com>
|
Independent Codex review is complete for Resolved findings:
No open P1/P2 remain. Final confirmation was limited to the authorized readiness switch, affected tests/docs, CI and formatting; unchanged gate/helper material and prior passing checks were reused. Focused race evidence covers helper custody/lost reply, exact numeric bytes, changed execution material, journal failures, one-use proofs, old-schema refusal and private-list isolation. The actual Desk → this Runner candidate → same authoring Runtime acceptance passed all four scenarios in 16.787s: exact registered input/withdrawal first, committed start before later withdrawal, lost start reply, and lost reserve reply. Linux also identified the live pinned Runtime, its audit and ownership lease, with no authority endpoint inherited. Candidate binary SHA256: Required full native CI is still a merge gate. Linux descriptor evidence does not establish native Darwin behavior; CI exercises that host. No guarantee is made against a hostile same-OS-user restoring the entire trusted plane. No release, live enrollment or installed Desk change is approved by this record. |
Signed-off-by: kikashy <kikashy@hotmail.com> Co-authored-by: Codex (gpt-6.1-sol) <noreply@openai.com>
|
Reviewed final head The first native CI run exposed three issues: private-field reflection coverage, a The dedicated nonexecuting helper now has a process-terminating entry point. Only this entry uses a held working directory and a uniquely named nondefault clone of SQLite's native VFS. Its bounded Subprocess regressions replace the named directory after adapter setup and prove database, journal, WAL and SHM writes reach the retained original. Actual preparation refuses replacement without publishing schema/demand/marker into either store. The FD observer now has a deliberately inherited socket negative control. Export coverage still asserts the exact public member set and explicit private exclusion. Affected helper race checks passed in 6.382s; the positive/negative FD checks passed in 3.235s after an isolated sandbox syscall refusal; export/CLI checks passed in 1.146s. Darwin arm64 compilation passed. The corrected actual binary ( The review verified all 14 correction files and the combined 58-file manifest ( The next CI attempt stopped at vet before any tests: three native-address casts were flagged. The reviewed one-file correction uses pinned libc native memcpy and typed compiler offsets/assignment, without suppressions or behavior changes. Explicit Linux and Darwin-target vet passed; the narrow actual helper/VFS race regressions passed in 11.481s. Other source bytes are unchanged. Final native CI remains the merge gate; Desk CI will run the final merged Runner source in the mandatory real acceptance fixture. On Final required CI is green at exact reviewed head |
Signed-off-by: kikashy <kikashy@hotmail.com> Co-authored-by: Codex (gpt-6.1-sol) <noreply@openai.com>
Signed-off-by: kikashy <kikashy@hotmail.com> Co-authored-by: Codex (gpt-6.1-sol) <noreply@openai.com>
An explicitly enabled
local-admin-manual-pack/1workspace now requires an exact approved Policy adoption, registered job release, original manual intent and fresh anchored start commitment before Runner can launch Runtime. A one-use proof binds the original authority session to verified Pack, input, Runtime, signing and ownership material. Lost replies and restored history remain observations and cannot launch work.The offline nonexecuting helper prepares store schema 4 under Desk's continuously held executor lease. Sticky external demand and the prepared store prevent silent fallback to legacy execution. Enabled workspaces refuse triggers, acquisition, mappings, workflows and upgrades; unconfigured workspaces preserve their existing behavior. Public list projections omit private admission metadata.
Validation includes actual Desk → Runner → Runtime race acceptance for exact numeric input, withdrawal ordering, delayed physical spawn, lost reserve/start replies and restart, plus the Linux live Runtime lease/authority-descriptor observer. Focused helper, copied-store, old-Runner, material mutation, failed persistence, one-use proof, privacy and affected CLI checks pass. CI requires named real helper/gate passes on both native hosts and the Linux descriptor observer.
Independent Codex review resolved the held-directory helper and public-list privacy findings; targeted final confirmation covers activation and integration evidence. This is same-vendor review under the maintainer's temporary waiver. Policy companion support remains experimental; this does not publish Runtime v0.35.0, alter published Desk component pins or change a live installation.