Repository navigation
Adopt the development kit: dev.json, scripts/dev/check.sh, AGENTS.md and CLAUDE.md, CI - #163
Merged
Merged
Conversation
…and CLAUDE.md, CI dev.json lists every check CI ran, in order, as a step with its toolchain and summary pattern, and adds three: the machine-local-path grep, the agent-docs sync check and git diff --check. The steps that checked out and built the pinned Runtimes, the old Runner and the Gateway are one step, scripts/checks/build-pinned.sh, which fetches each pin into .ci/ (ignored by git); the longer test steps are scripts under scripts/checks/ with the comments they had in the workflow. scripts/dev/check.sh and scripts/sync-agent-docs.sh are vendored from the development kit v0.1.0. AGENTS.md and CLAUDE.md carry the shared rules and a section for this repository. The test job is now `check`, still named `Runner (<os>)`, and runs the manifest on Linux and macOS; `Release contents` keeps its name and runs the release steps of the manifest. release.yml still calls ci.yml. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com>
Contributor
Author
Narrow review record (same vendor, not a cross-vendor claim)Reviewer: one clean-room Claude Sonnet agent over the five adoption pull requests (runtime #300, gateway #302, runner #163, spec #220, exchange #31), read-only, no suite re-run; CI logs and workflow diffs read. The common part and this repository's part of the verbatim report follow. All five repositories:
Verdict: mergeable — head b9d0777 Disposition
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
dev.json: every check CI ran, as an ordered step with its toolchain and summary pattern, plus three new ones: the machine-local-path grep, the agent-docs sync check andgit diff --check. Nothing CI ran is dropped.scripts/dev/check.sh(vendored from the development kit v0.1.0, unchanged) andscripts/sync-agent-docs.sh.AGENTS.mdandCLAUDE.md(identical): the kit's shared rules, then a "This repository" section.scripts/checks/build-pinned.sh: the four checkout-and-build steps (the tested Runtime, the ownership-era Runner, the earlier Runtime, the Gateway) as one step. Each pin is fetched by commit into.ci/(ignored by git) and built into.ci/bin; the pins, the release names beside them and their comments are as they were in the workflow.scripts/checks/manual-gate.sh,unit-tests.sh,chain-tests.sh,release-toolchain.sh,release-programs.sh: the multi-line steps as scripts, unchanged except that binaries are read from.ci/bininstead of$RUNNER_TEMPand the Linux-only assertions testuname -sinstead of$RUNNER_OS.scripts/checks/local-paths.sh: the grep. Four files are not counted, where a/tmppath is a synthetic example, test input or a command in a design note written before this check existed (docs/design/executor-ownership.md,docs/design/manual-admission-store-prepare-shape.md,docs/design/manual-admission-store-prepare-wire.json,internal/runner/cloud_test.go).go fmtplusgit diff --exit-codebecame agofmt -lcheck that does not rewrite files;go buildof the two programs writes to/dev/null..gitignore:/.ci/. README: a short paragraph onscripts/dev/check.shand the agent docs, under "Verification".CI
Before:
test("Runner (ubuntu-latest)", "Runner (macos-latest)") andrelease-contents("Release contents").After:
check(job id; still namedRunner (<os>), same two operating systems, same 15-minute limit) runsscripts/dev/check.sh --manifest dev.json --only local-pathsfirst, sets up Go1.26.x, then runsscripts/dev/check.sh --allwithout the four release steps.release-contents(still "Release contents", Go1.26.5) runs those four release steps withscripts/dev/check.sh --all --only ....workflow_callis kept andrelease.ymlis not changed.Required status checks on
main, all kept as job names:Runner (ubuntu-latest),Runner (macos-latest),Release contents,DCO. The runner has not been run on a macOS runner before this pull request; its CI run is that first run.Checks
scripts/dev/check.sh --all, run once from the clone root at the head commit, with Python 3.12:actionlint .github/workflows/ci.yml: clean.git diff --check: clean.Material-decision impact: tooling and CI (no product code); a narrow review follows, run by the coordinator.
🤖 Generated with Claude Code