Skip to content

test: hold Idempotency-Key length and visible ASCII range (#71) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Haxxyyyy wants to merge 2 commits into from
Closed

test: hold Idempotency-Key length and visible ASCII range (#71) #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c0d9e
test: cover idempotency key ASCII and length boundaries
Haxxyyyy Oct 14, 2026
376b07a
test: use actual control bytes in idempotency key cases
Haxxyyyy Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions internal/runner/events_admission_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,39 @@ func TestEveryAdmissionRefusalIsJournaledOnce(t *testing.T) {

// The store-wide route for a job serves what the job's route does, its
// release's preview included, and Runner's own entries besides.
func TestSubmitRunIdempotencyKeyVisibleASCIIBoundaries(t *testing.T) {
s := openJournal(t, journalConfig(t))
t.Cleanup(func() { s.Close() })

cases := []struct {
name string
key string
want int
}{
{"one character", "k", 404},
{"128 characters", strings.Repeat("k", 128), 404},
{"first visible character", "!", 404},
{"last visible character", "~", 404},
{"empty", "", 400},
{"129 characters", strings.Repeat("k", 129), 400},
{"space", "a b", 400},
{"control character", "a\x01b", 400},
{"DEL", "a\x7fb", 400},
{"non-ASCII letter", "é", 400},
}

for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
got := serve(t, s, "POST", "/v1/jobs/job_unknown/runs", `{"facts":{}}`, map[string]string{
"Idempotency-Key": c.key,
})
if got.Code != c.want {
t.Fatalf("answered %d, want %d; body: %s", got.Code, c.want, got.Body.String())
}
})
}
}

func TestTheStoreWideRouteForAJobHasItsReleasesEntries(t *testing.T) {
w := newCoverWorld(t)
var page EventPage
Expand Down