Repository navigation
Adopt the development kit: dev.json, scripts/dev/check.sh, AGENTS.md and CLAUDE.md, CI - #300
Merged
Merged
Conversation
…and CLAUDE.md, CI dev.json lists the checks in order. Three are new: the machine-local-path grep, the agent-docs sync check and git diff --check. The rest are what CI ran: gofmt, go vet, go test, the bundled conformance suite, the build and the MCP registry template validation (moved to scripts/check-registry-template.py, which renders the template in memory instead of through a temporary file). scripts/dev/check.sh and scripts/sync-agent-docs.sh are vendored from the development kit v0.1.0. AGENTS.md and CLAUDE.md carry the shared rules and a section for this repository. CI gains a `check` job that runs the manifest; the `test` matrix keeps its job names, which branch protection requires. The local-path grep skips one test vector that holds a file URI, and the trailing space in the ADR template is removed so git diff --check passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com>
Contributor
Author
Narrow review record (same vendor, not a cross-vendor claim)Reviewer: one clean-room Claude Sonnet agent over the five adoption pull requests (runtime #300, gateway #302, runner #163, spec #220, exchange #31), read-only, no suite re-run; CI logs and workflow diffs read. The common part and this repository's part of the verbatim report follow. All five repositories:
Verdict: mergeable — head f816d95 DispositionThe common LOW (the runner's missing version comment) goes to the devkit (its template carries the line). Merged on green CI. |
|
🎉 Thank you for your contribution to Judgment Pack! If you’d like another task, choose a path that interests you: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
dev.json: the check list, in order. New: the machine-local-path grep, the agent-docs sync check andgit diff --check. Kept: gofmt,go vet,go test, the bundled conformance suite, the build, and the MCP registryserver.jsontemplate validation. Nothing CI ran is dropped.scripts/dev/check.sh(vendored from the development kit v0.1.0, unchanged) andscripts/sync-agent-docs.sh.AGENTS.mdandCLAUDE.md(identical): the kit's shared rules, then a "This repository" section.scripts/check-registry-template.py: the registry template validation moved out of the workflow sodev.jsoncan run it. It renders the template in memory instead of through a temporary file; the schema and the extra OCI rules are the same.internal/policy/testdata/candidate-uri-cases.json) that holds afile:///tmp/exampleURI, which is test data and not a machine-local path.docs/adr/template.md: one trailing space removed sogit diff --checkpasses over the whole tree..gitignore:/.venv/. README and CONTRIBUTING: a short paragraph onscripts/dev/check.shand the agent docs.CI
Before:
test(a matrix of four legs) andregistry-template("MCP registry server.json template").After:
testis unchanged (same step list, same four job names).registry-templateis replaced bycheck, which runsscripts/dev/check.sh --manifest dev.json --only local-pathsfirst, sets up Go and Python, then runsscripts/dev/check.sh --setupandscripts/dev/check.sh --all.release.ymlis not changed; it does not call CI.Required status checks on
main, all kept:ubuntu-latest · Go stable,macos-latest · Go stable,windows-latest · Go stable,ubuntu-latest · Go 1.24.x,DCO.registry-templatewas not a required check. Thetestmatrix legs keep their own copy of the Go steps because the runner has not been exercised on the macOS and Windows runners;AGENTS.mdsays so.Checks
scripts/dev/check.sh --all, run once from the clone root at the head commit, with Python 3.12:actionlint .github/workflows/ci.yml: clean.git diff --check: clean.Material-decision impact: tooling and CI (no product code); a narrow review follows, run by the coordinator.
🤖 Generated with Claude Code