Skip to content

Adopt the development kit: dev.json, scripts/dev/check.sh, AGENTS.md and CLAUDE.md, CI - #300

Merged
kikashy merged 1 commit into
mainfrom
adopt-devkit
Oct 20, 2026
Merged

kikashy merged 1 commit into
mainfrom
adopt-devkit

Conversation

@kikashy

@kikashy kikashy commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

What changes

  • dev.json: the check list, in order. New: the machine-local-path grep, the agent-docs sync check and git diff --check. Kept: gofmt, go vet, go test, the bundled conformance suite, the build, and the MCP registry server.json template validation. Nothing CI ran is dropped.
  • scripts/dev/check.sh (vendored from the development kit v0.1.0, unchanged) and scripts/sync-agent-docs.sh.
  • AGENTS.md and CLAUDE.md (identical): the kit's shared rules, then a "This repository" section.
  • scripts/check-registry-template.py: the registry template validation moved out of the workflow so dev.json can run it. It renders the template in memory instead of through a temporary file; the schema and the extra OCI rules are the same.
  • The local-path grep skips one test vector (internal/policy/testdata/candidate-uri-cases.json) that holds a file:///tmp/example URI, which is test data and not a machine-local path.
  • docs/adr/template.md: one trailing space removed so git diff --check passes over the whole tree.
  • .gitignore: /.venv/. README and CONTRIBUTING: a short paragraph on scripts/dev/check.sh and the agent docs.

CI

Before: test (a matrix of four legs) and registry-template ("MCP registry server.json template").

After: test is unchanged (same step list, same four job names). registry-template is replaced by check, which runs scripts/dev/check.sh --manifest dev.json --only local-paths first, sets up Go and Python, then runs scripts/dev/check.sh --setup and scripts/dev/check.sh --all. release.yml is not changed; it does not call CI.

Required status checks on main, all kept: ubuntu-latest · Go stable, macos-latest · Go stable, windows-latest · Go stable, ubuntu-latest · Go 1.24.x, DCO. registry-template was not a required check. The test matrix legs keep their own copy of the Go steps because the runner has not been exercised on the macOS and Windows runners; AGENTS.md says so.

Checks

scripts/dev/check.sh --all, run once from the clone root at the head commit, with Python 3.12:

== check summary (dev.json) ==
PASS     local-paths              0s
PASS     agent-docs               0s
    sync-agent-docs: CLAUDE.md matches AGENTS.md
PASS     diff-check               0s
PASS     go-fmt                   0s
PASS     go-vet                   0s
PASS     go-test                  19s
    24 lines matched; last: ok  	github.com/Judgment-Pack/judgment-pack-runtime/tools/sync-spec-artifacts	0.153s
PASS     conformance              0s
PASS     build                    0s
PASS     registry-template        0s
    registry template: valid
== 9 passed, 0 failed, 0 skipped, 0 not run ==

actionlint .github/workflows/ci.yml: clean. git diff --check: clean.

Material-decision impact: tooling and CI (no product code); a narrow review follows, run by the coordinator.

🤖 Generated with Claude Code

…and CLAUDE.md, CI

dev.json lists the checks in order. Three are new: the machine-local-path grep, the
agent-docs sync check and git diff --check. The rest are what CI ran: gofmt, go vet,
go test, the bundled conformance suite, the build and the MCP registry template
validation (moved to scripts/check-registry-template.py, which renders the
template in memory instead of through a temporary file).

scripts/dev/check.sh and scripts/sync-agent-docs.sh are vendored from the
development kit v0.1.0. AGENTS.md and CLAUDE.md carry the shared rules and a
section for this repository. CI gains a `check` job that runs the manifest;
the `test` matrix keeps its job names, which branch protection requires.

The local-path grep skips one test vector that holds a file URI, and the
trailing space in the ADR template is removed so git diff --check passes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com>
@kikashy

kikashy commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Narrow review record (same vendor, not a cross-vendor claim)

Reviewer: one clean-room Claude Sonnet agent over the five adoption pull requests (runtime #300, gateway #302, runner #163, spec #220, exchange #31), read-only, no suite re-run; CI logs and workflow diffs read. The common part and this repository's part of the verbatim report follow.


All five repositories:

  • scripts/dev/check.sh is byte-identical to the devkit's templates/check.sh. It has no version comment at all (LOW: nothing in the file records v0.1.0; the PR body says so).
  • scripts/sync-agent-docs.sh is identical.
  • AGENTS.md and CLAUDE.md are identical to each other. Against the template, AGENTS.md differs only by the appended "## This repository" section, and no template line changed.
  • The agent-docs step in dev.json checks CLAUDE.md against AGENTS.md (as in agent PR Automate post-merge contributor recommendations #88). Nothing in CI compares them to the template.
  • No product files are touched: the changed files are only workflows, scripts, the four docs files, dev.json and ignore or attribute files. runtime also edits docs/adr/template.md (one trailing space removed) and adds scripts/check-registry-template.py.
  • git diff --check is clean, actionlint is clean, and there is no personal name or machine-local path in any added line.
  • No manifest step uses optional or requires_env.
    runtime Adopt the development kit: dev.json, scripts/dev/check.sh, AGENTS.md and CLAUDE.md, CI #300, head f816d95
  • Findings: none.
  • Q1: The required contexts (4 test legs, DCO) are unchanged. The registry-template job became the step registry-template (new script, same schema and OCI rules, and it was not a required context). release.yml does not call ci.yml. The local-paths grep is new.
  • Q2: Template files match, as above.
  • Q3: Each step is a real command. The one exclusion is internal/policy/testdata/candidate-uri-cases.json, which holds file://<tmp>/example as test data. That is acceptable. The PR body's summary block shows 9/9 passed.
  • Q4: check ran 9 steps in CI, 9 passed, 0 skipped.
  • Q5: Clean.

Verdict: mergeable — head f816d95


Disposition

The common LOW (the runner's missing version comment) goes to the devkit (its template carries the line). Merged on green CI.

@kikashy
kikashy merged commit 181b634 into main Oct 20, 2026
6 checks passed
@kikashy
kikashy deleted the adopt-devkit branch October 20, 2026 16:00
@github-actions

Copy link
Copy Markdown

🎉 Thank you for your contribution to Judgment Pack!

If you’d like another task, choose a path that interests you:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant