Repository navigation
Allow Zarr 0.11 in ZarrExt - #72
Open
alex-s-gardner wants to merge 1 commit into
Open
alex-s-gardner wants to merge 1 commit into
alex-s-gardner wants to merge 1 commit into
Conversation
Zarr.jl 0.11 moves its implementation into `ZarrCore`, and `Zarr` re-exports only `ZarrCore`'s public names. `MetadataV2`, `MetadataV3` and `to_zarrtype` are not among them, so `ZarrExt` fails to load against Zarr 0.11 with ``UndefVarError: `MetadataV3` not defined``. The extension now imports those three from `Zarr.ZarrCore`. That module does not exist in 0.10, so the `Zarr` compat moves from `0.10` to `0.11` rather than widening. The version goes to 0.7.12. The test suite passes locally against Zarr 0.11.1 (Julia 1.13). Co-authored-by: Claude 🤖 <noreply@anthropic.com>
Member
|
Thanks. I am wondering whether we should rather make YAXArrayBase only depend on ZarrCore. And make the extension trigger on ZarrCore instead of Zarr. I am going to open a PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 52.04% 52.04%
=======================================
Files 12 12
Lines 490 490
=======================================
Hits 255 255
Misses 235 235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zarr.jl 0.11 moves its implementation into
ZarrCore, andZarrre-exports onlyZarrCore's public names.MetadataV2,MetadataV3andto_zarrtypeare not among them, soZarrExtfails to load against Zarr 0.11 withUndefVarError: `MetadataV3` not defined. The extension now imports those three fromZarr.ZarrCore. That module does not exist in 0.10, so theZarrcompat moves from0.10to0.11rather than widening. The version goes to 0.7.12.The test suite passes locally against Zarr 0.11.1 (Julia 1.13).
Co-authored-by: Claude 🤖 noreply@anthropic.com