Add missing synchronization2 feature check and enable flag - #442
Open
CatB1t wants to merge 5 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither the docs nor the source files check for or enable the synchronization2
feature before
15_hello_triangle.cpp, which uses the sync2 API. It's correctly enabledin that chapter's own source, but not in anything prior to it, so anyone following the
tutorial in order hits a validation error (feature not enabled) when they get there.
This PR adds the support check and the enable flag to the docs and the attachment
sources for the chapters leading up to it.