Repository navigation
cli: expand GitHub owner/repo shorthand in add-repo - #7
Open
zampierilucas wants to merge 27 commits into
Open
zampierilucas wants to merge 27 commits into
zampierilucas wants to merge 27 commits into
Conversation
The Kindle searchbar runs ; commands through scriptExecutor, which only lets [A-Za-z0-9/_ -] through in arguments, so a URL can never reach add-repo from there. Expand owner/repo[/path] into a raw GitHub URL on the default branch, with path defaulting to manifest and .json appended. Fixes KindleModding#5 Signed-off-by: Lucas Zampieri <lcasmz54@gmail.com>
ThatHackerDudeFromCyberspace
force-pushed
the
main
branch
from
October 22, 2026 10:15
215736c to
4a052fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searchbar `;` commands go through Amazon's `scriptExecutor`, which only lets `[A-Za-z0-9/_ -]` through in arguments, so add-repo can never get a URL from there (see #5).
This expands `owner/repo[/path]` into a raw GitHub URL on the default branch, with path defaulting to `manifest` and `.json` appended, so `;kpm add-repo KindleTweaks/Repo` works from the searchbar. Anything with a `.` or `:` in it goes through untouched like before.
Tested on a host build with `KindleTweaks/Repo`, `zampierilucas/kindle-hid-passthrough/kpm/repo` and `zampierilucas/kindle-button-mapper-rs/kpm/repo`, all three add and index fine after `kpm update`.
Fixes #5