Repository navigation
Conversation
… every launch Every launch called utimes() on the scriptlet and set com.lab126.scanner doFullScan. The scan then saw a modified .sh and emitted SCANNER_UPDATE, which the extractor handles as remove_file() + index_file(): the cc.db entry is deleted and re-inserted under a new UUID. In that window the entry shows up as "Black-listed content - In progress", the indexer loops on DELETE work items for it, and the home app's native-thread freeze watchdog fires (dmcc bundles in /documents, Indexer_Dump_*.txt in the root, white screen / home reload loop, sometimes the troubleshooting screen). Reproduced on a Colorsoft (042-juno_1906_seabreeze_bellatrix4-483218) on five separate days; the only thing the bump bought was moving the scriptlet to the front of the Recent sort. Fixes KindleModding#4
Author
|
@yubaix thanks for looking. Closed without a note, so I'm not sure which way you'd like this to go — is the per-launch full scan intentional and you'd rather keep "bring to front", or would you prefer the fix on the extractor side (make SCANNER_UPDATE an in-place update instead of delete + re-insert, so the entry never goes through the "In progress" blacklist window)? Either is fine by me; #4 is still reproducing on the Colorsoft and I'm happy to rework this whichever way fits the project. |
Member
|
This PR doesn't fix the issue properly imo, I'll fix it myself, most likely tomorrow |
Author
|
@ThatHackerDudeFromCyberspace Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
go_callbackcalledutimes()on the scriptlet and setcom.lab126.scanner doFullScanon every launch. The scan then sees a modified.shand emitsSCANNER_UPDATE, whichextractor/main.chandles asremove_file()+index_file()— the cc.db entry is deleted and re-inserted under a new UUID. In that window the entry is "Black-listed content – In progress", the indexer loops onDELETEwork items for it (Indexer_Dump_*.txtin/mnt/us), andKPPMainApp's native-thread freeze watchdog fires (dmccbundles in/documents, white screen / home reload loop, occasionally the troubleshooting screen). Reproduced on a Colorsoft (042-juno_1906_seabreeze_bellatrix4-483218) on five separate days; worst when a launch follows a USB unplug (a full scan is already running) or is followed by a quick exit.This removes the bump. Cost: the scriptlet no longer jumps to the front of the Recent sort after a launch. If that's wanted, an in-place
lastAccessupdate on the existing entry would achieve it without a rescan — happy to do that as a follow-up.Tested by reading the code paths only; I can't cross-compile here, so the CI cross-build will cover it. On-device evidence (syslog timeline, indexer dumps) is in #4.