Repository navigation
Fix stereo import - #2037
Merged
Merged
Fix stereo import#2037
Conversation
Multicam finalize runs on localworker, where girder_worker creates child jobs over REST with the parent task's job-scoped token, which cannot create jobs. The conversion task then ran without a job and crashed, so stereo imports never got their converted calibration. Create the Girder job directly when enqueuing off-request and publish with its jobInfoSpec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix web stereo imports not linking as stereo. Since multicam finalize moved to a background task on the
localqueue (#2019), stereo imports with a calibration file failed at the linking step. The camera folders (left,right) were left behind as separate datasets under a parent that never became a stereo dataset.Root cause
create_multicamreads the calibration file's bytes to check whether it is already-final JSON. That used to run inside the Girder REST request. It now runs inlocalworker, which did not mountgirder_assetstore, so the read failed withGirderException: File /home/assetstore/... does not existand the finalize job errored. The same missing mount also meant annotation stats reports written bylocalworkerwere never saved where Girder could read them.Changes
server/dive_server/crud_dataset.py:_calibration_file_is_final_jsonreturns early for non-.jsonnames, so.npz/.cam/etc. are never read.docker-compose.yml: mountgirder_assetstore:/home/assetstoreonlocalworker.docs/Architecture-For-New-Developers.md: note thatlocalworkerruns Girder models in-process and must share thegirderfilesystem assetstore.Self-hosted deployments with a filesystem assetstore need the same volume on
localworker. S3 assetstores are unaffected.