Repository navigation
Use ASCII case folding for case-insensitive attribute selectors - #37
Closed
jwalith4418-Mj wants to merge 1 commit into
Closed
jwalith4418-Mj wants to merge 1 commit into
jwalith4418-Mj wants to merge 1 commit into
Conversation
Apply the existing ascii_lower helper to both operands of i-flag comparisons, as required by Selectors Level 4. Cover all six operators, HTML/XML, non-ASCII-to-ASCII folds and explicit/default case controls. AI-assisted investigation, implementation and validation using OpenAI Codex.
Member
|
Please follow the contribution guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case-insensitive attribute selectors currently apply Python's Unicode
.lower()to both operands. Consequently,[data-value="ÉA" i]incorrectly matches an attribute containingéa, and[data-value="k" i]matches the Kelvin signK.Selectors Level 4, section 6.3 restricts the
iflag to ASCII case-insensitive matching, independently of the document language. Use the existingwebencodings.ascii_lowerhelper for the selector constant and the generated attribute-value expression. That helper is already imported and available to compiled selectors. ASCII case differences still match; non-ASCII characters retain their identity.The regression cases exercise all six attribute-value operators in both HTML and XML, distinguish accented uppercase/lowercase values, cover Unicode characters whose lowercasing introduces ASCII characters, and retain unflagged/
s/Sandi/IASCII controls.Validation:
--sourcetakes precedence over the project'sincludesetting.python -m ruff check, Sphinx HTML, wheel/sdist andgit diff --check: passed.The full CI interpreter/platform matrix was not run locally. This was found during source inspection and reproduced through the public API. OpenAI Codex assisted with investigation, implementation, validation and this description.