Use the built-in JSON stream configuration provider - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the custom JSON-to-configuration flattening pipeline with the built-in .NET JSON stream configuration provider.
MemoryStreamwithUtf8JsonWriterJsonTypeInfo<T>serialization pathsFeatures:PaymentsJsonStreamConfigurationSourceAddObjectprecedence by appending the sourceAddObjectAsFallbackprecedence by inserting the source at index 0Build()JsonConfigurationFlattener,ObjectConfigurationSource, andObjectConfigurationProviderMicrosoft.Extensions.Configuration.Jsonas the implementation dependencyValidation
The test suite was expanded before the implementation change and passed against the previous flattener-based implementation. The new stream-provider implementation then passed the same contract before cleanup. After removing the obsolete implementation and migrating the remaining edge cases to integration coverage, the full CI pipeline is green again.
Integration coverage includes direct configuration keys, binding into different but equivalent types, nested objects, fallback precedence, multi-level root sections,
JsonTypeInfo<T>, scalar values with an explicit root, and rejection of rootless scalar JSON.Public API
No public API changes are introduced: