Repository navigation
lint(fabtoken): split gocognit fixes out of #2327 - #2529
Open
EaswarKilari wants to merge 1 commit into
Open
EaswarKilari wants to merge 1 commit into
EaswarKilari wants to merge 1 commit into
Conversation
adecaro
self-requested a review
October 26, 2026 12:12
adecaro
force-pushed
the
2379-gocognit-fabtoken
branch
from
October 26, 2026 13:21
3e98821 to
90a08a4
Compare
Bring token/core/fabtoken under the gocognit limit (15) by extracting the flagged functions into named helpers. No behaviour change. Fixes LFDT-Panurus#2379 Signed-off-by: Easwar Kilari <81870353+EaswarKilari@users.noreply.github.com>
EaswarKilari
force-pushed
the
2379-gocognit-fabtoken
branch
from
October 31, 2026 09:56
90a08a4 to
32c7593
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2379
Part of the gocognit cleanup in #2377, same approach as #2390 and #2394.
Eight functions in token/core/fabtoken were over the complexity limit of 15. I split them into smaller helpers without changing behaviour. The checks, their order and the error messages are the same as before.
The highest score among the changed functions is now 13.. No nolint directives were added.
Tested with:
Integration tests were not run locally.