[adecaro]

Summary

Part of a series of parity PRs against feature/zkat-snark-driver (#2590, #2591, #2592 and others) that close the gaps between the zkatsnark driver and zkatdlog. This PR covers the integration gap.

Before this PR, the fabricx ZKAT-SNARK suite (integration/token/fungible/zkatsnark) ran only T1-T5. The fabtoken -> ZKAT-SNARK upgrade from #2551 was covered only by unit and regression tests. This PR brings the suite in line with the fabricx ZKAT-DLOG suite (integration/token/fungible/dlogx) and adds fabtoken -> ZKAT-SNARK upgrade suites.

What changed

Commit 1: test(integration): support fabtoken upgrade scenarios on fabricx (test plumbing only, no production code)

• fabricx backend skips transient TMSs. Backend.PrepareNamespace and Backend.InstallPublicParams (integration/nwo/token/fabricx/factory.go) now return early for tms.Transient, as the Fabric chaincode backend (tcc.go) already does. Without this, the extra TMS fails with "missing orgs", and its public params get installed at bring-up, before the fabtoken phase runs. Unit tests added.
• Topology applies endorsement settings to extra TMSs. The FSC endorsement, policy type, namespace policy and own-org settings are now applied to extra TMSs too. Without this, their merged config wipes the default TMS's fsc_endorsement block. Unit tests cover endorsement on and off.
• The fzkatsnark SDK registers the fabtoken token and validator drivers, which the upgrade suites need. This has no effect on pure zkatsnark networks.
• New TestTokensUpgradeWithAlias / TestLocalTokensUpgradeWithAlias in integration/token/fungible/tests.go. The existing TestTokensUpgrade / TestLocalTokensUpgrade are now thin wrappers that pass "dlog-32bits", so the Fabric update suite works as before.

Commit 2: test(zkatsnark): mirror dlogx scenarios and add fabtoken upgrade suites

• integration/token/fungible/zkatsnark/zkatsnark_test.go adds:
  • T6/T7: Auditor = Issuer, then a public-params update
  • T8: Fabric CA, non-Aries (the only integration coverage of the non-Aries zkatsnark path)
  • T9: malicious transactions
  • T11: token selector (WebSocket, as in dlogx)
  • T12: multisig
  • T13: redeem to self
  • T14: policy identity OR/AND
  • T17: fabtoken 64-bit -> ZKAT-SNARK 32-bit (burn and re-issue)
  • T18: fabtoken 32-bit -> ZKAT-SNARK 32-bit (spent in place)
  • Shared setup is factored into newSuite / newUpgradeTestSuite.
• fabricx.mk: targets integration-tests-fabricx-zkatsnark-t6 through -t18.
• .github/workflows/tests.yml: enables t6, t7, t8, t9, t11, t12, t13, t17 and t18. t14 is in the matrix but commented out until the boolpolicy audit-info deserializer fix (feat(zkatsnark): honour resource limits, add circuit breaker, fix boolpolicy audit info deserializer #2591) is merged.
• Docs: docs/drivers/zkatsnark.md (test coverage), docs/development/testing.md, docs/development/debug-integration-tests.md.

How it was tested

The integration scenarios were NOT run locally, by instruction. CI validates them. Locally, the new specs were only compile-checked.

Commands run (all passing):

cd integration && go build ./...
cd integration && go vet ./nwo/token/fabricx/ ./token/fungible/... ./token/common/sdk/fzkatsnark/
cd integration && go test -count=1 ./nwo/token/fabricx/ ./token/fungible/topology/ ./token/common/sdk/fzkatsnark/
cd integration && go test -run '^$' ./token/fungible/zkatsnark/ ./token/fungible/update/ ./token/fungible/dlogx/
cd integration && golangci-lint run ./nwo/token/fabricx/... ./token/fungible/ ./token/fungible/topology/... ./token/fungible/zkatsnark/... ./token/common/sdk/fzkatsnark/   # 0 issues
gofmt -l <touched packages>   # clean

Scenarios with dependencies or runtime risk

• T14 (policy OR/AND) depends on feat(zkatsnark): honour resource limits, add circuit breaker, fix boolpolicy audit info deserializer #2591 (boolpolicy audit-info deserializer fix: zkatsnark registers &boolpolicy.AuditInfoDeserializer{} with a nil inner deserializer). Its CI entry stays commented out until feat(zkatsnark): honour resource limits, add circuit breaker, fix boolpolicy audit info deserializer #2591 merges.
• Auditor-related scenarios (T6/T7 Auditor = Issuer, T9 / T13 auditor checks) may also depend on the zkatsnark auditor parity PR. If they fail in CI for auditor-side reasons, that PR should land first.
• Scenarios that touch areas changed by fix(zkatsnark): use the standard authorization chain order #2590 (validator/transfer paths exercised by T9, T12 and T13) may depend on fix(zkatsnark): use the standard authorization chain order #2590.
• T7, T9 and T12 are enabled here, but they are disabled for fabricx-dlog under Re-enable commented-out integration test matrix entries in tests.yml #1945. CI will show whether they pass on fabricx-zkatsnark.
• T8 and the fabtoken Fabric-CA setup used by T17/T18 have never been run on fabricx. If T8 fails for a fabricx-specific reason, it will be dropped and documented.
• T7 does not mirror dlogx's endorser-restart argument.

Out of scope / follow-ups

• T15 (own-org endorsers) and T16 (2-of-3 namespace policy): these are backend endorsement features and do not depend on the driver.
• The update-suite Idemix issuer key rotation scenario. It would need a second zkatsnark TMS.
• TestDLogTokensUpgrade (Pedersen generator regeneration) applies only to DLog, so there is no zkatsnark equivalent.
• Enable T14 in CI once feat(zkatsnark): honour resource limits, add circuit breaker, fix boolpolicy audit info deserializer #2591 merges.