Repository navigation
feat: replace per-template render scripts with a catalog and payload strategies - #196
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the duplicated per-template files and replaces them with one CLI plus a catalog. Sample payloads now live next to that CLI.
Design
scripts/catalog.ts— oneRenderTargetper id. Campaigns (mysterium, flat-file-7) reuse a template with an override payload. Adding a template is one entry, not a new file.scripts/payloads.ts— Chain of Responsibility:--payload '{...}'inline JSON--input file.jsonwhen data is passed from outsideloadPayload()(campaign override)scripts/render.ts— single entry:node dist/scripts/render.js --template <id> [--output path] [--input data.json] [--payload '{...}']scripts/samples/— sample payloads moved out ofsrc/samples. Register files and tests import from here.Non-JSON
--inputvalues (the action still passes the script path) are ignored, so current CI keeps working.Also
render:*npm script now calls the shared CLI with--template.scripts/render.ts.scripts/render-*.tscopies,render-entry.ts, andsrc/samples/.test/scripts/render-catalog.test.tscover the catalog, args, and strategy order.No local builds or tests were run.