Repository navigation
Conversation
Replace the hand-rolled wrapGoodNewsDocument with document() from @llazyemail/template-runtime-display. Passes lang: false and the page background via bodyAttributes. Fixes the previous double </body>. Requires the next runtime release that adds the shell options.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the good-news renderer off its hand-rolled document wrapper and onto
document()from@llazyemail/template-runtime-display.Changes
wrapGoodNewsDocumentnow callsdocument({ lang: false, headHtml: goodNewsHeads(...), bodyAttributes: 'style=...', mainHtml }).</body>bug.lang, page background on<body>.Dependency
Requires the next
@llazyemail/template-runtime-displayrelease that adds the configurable shell options (lang,bodyAttributes, etc.). Safe to merge after that release is published and the dependency is bumped.The current published 0.9.x does not yet accept these options.