Repository navigation
feat: include the failing command's cause in the error annotation - #26
Merged
Merged
Conversation
Rendered emailsThis PR rendered email templates.
Open the run → Artifacts → download → open |
…indows The previous node -e interpolated $PROJ (Git Bash path) into a string that Node treats as a Windows path, producing ENOENT on package.json. cd into the project and use a relative path instead, matching the existing validate-email deletion case.
The index.html writer escapes &, <, > so the tests must look for a&b.html and a<b>.html, not the raw characters.
The index.html writer escapes special characters, so the tests must look for the escaped forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action already printed "the script's own output is above". In the check summary that is not enough: a
tscfailure (for exampleCannot find module '../../../src/types.js') only showed up if you opened the full log.Change
scripts/render.shnow captures the failed command's output.error TS...,Cannot find module,ERR_MODULE_NOT_FOUND,SyntaxError,TypeError,Error:).::error::annotation, and the failure block reprints it plus the last 20 lines.A failing
npm run render:hackernoonthat dies on a missing module now annotates:Test
tests/render.test.shasserts the annotation includes atsc-style cause.main.