Skip to content

update later changes in template generator probably? #27

Closed

Description

@atherdon

Issue #25 is: the engine should only catalog + render + payload. Disk belongs in markup-generator (writes already did; reads should too).

Two PRs:

1. markup-generator #275

New public helpers:

  • pathExists(path)
  • listTemplateFiles(dir, { skipFiles, extensions }) — missing dir → []

loadData / readJson / writeGeneratedFile were already here.

2. generate-template #26

  • src/adapters/list-files.ts → listTemplateFiles from markup-generator
  • src/adapters/payload-files.ts → loadData + pathExists
  • generator.ts no longer imports node:fs
  • No default dataDir probe. Missing payload throws NO_PAYLOAD unless you pass payload, dataPath, samplePayloads, loadPayload, or useDataFiles: true

Merge order: #275 → publish markup-generator → bump the dependency → merge #26.

Still later (issue PR C): move spawnSync file-renderer so render.ts is also fs-free. Not in these PRs.

Originally posted by @atherdon in #25

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions