Repository navigation
refactor: use runtime xhtmlDocument() for the XHTML shell - #63
Merged
Merged
Conversation
atherdon
force-pushed
the
refactor/postmark-xhtml-document
branch
from
October 29, 2026 17:50
bdeadf6 to
bfbfe10
Compare
atherdon
changed the base branch from
refactor/postmark-document-slots
to
main
October 29, 2026 17:50
This was referenced Oct 29, 2026
atherdon
force-pushed
the
refactor/postmark-xhtml-document
branch
from
October 29, 2026 17:54
bfbfe10 to
98aac67
Compare
Rendered emailsThis PR rendered email templates.
Open the run → Artifacts → download → open |
Bump @llazyemail/template-runtime-display to 1.2.1 and route the Postmark document through xhtmlDocument() (XHTML doctype, xmlns, no lang). Preheader uses the preheaderHtml slot; the Postmark shell stays mainHtml with the footer inside the shell table. Drop the unused postmarkBody helper. Co-authored-by: petroved <arthur.tkachenko.netweight@gmail.com>
atherdon
force-pushed
the
refactor/postmark-xhtml-document
branch
from
October 29, 2026 17:56
98aac67 to
81644b1
Compare
atherdon
marked this pull request as ready for review
October 29, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild of this PR on current
main. Uses the latest published@llazyemail/template-runtime-display@1.2.1and routes the Postmark document shell through runtimexhtmlDocument().Supersedes #58 and #61 (their stacked
document()/ slot work is folded into this single-purpose change).Changes
@llazyemail/template-runtime-display0.9.0→1.2.1(includesxhtmlDocument()).renderPostmarkDocumentcallsxhtmlDocument({ headHtml, preheaderHtml, mainHtml }).mainHtml; footer stays inside the shell table on purpose (runtimefooterHtmlwould land outside.email-contentand change layout).postmarkBody.ts; drop unusedbody/BodyPropsre-exports fromblocks.ts.Runtime fit
xhtmlDocument()fits Postmark’s shell: XHTML 1.0 Transitional doctype,xmlns="http://www.w3.org/1999/xhtml", nolang. No extrahtml/bodyattributes were needed, sodocument()with a manual XHTML doctype was not required.Output vs main
Semantically equivalent (whitespace-normalized HTML matches). Byte-level diffs are whitespace only:
<head>/<body>(runtime shell owns those tags)Dependency / auth
mainalready has #65 (.npmrc+ workflowNODE_AUTH_TOKENfor GitHub Packages). No further npmrc changes in this PR.Test plan
npm run lintnpm test(147)npm run test:real-data(21)npm run generate:template -- --all+npm run generate:assert