Skip to content

Fix CI format check and ESLint workflow - #16

Merged
atherdon merged 1 commit into
mainfrom
fix/ci-prettier-and-eslint
Oct 3, 2026
Merged

atherdon merged 1 commit into
mainfrom
fix/ci-prettier-and-eslint

Conversation

@atherdon

@atherdon atherdon commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Format the files Prettier rejects on main (.github/workflows/codeql.yml, .github/workflows/eslint.yml, and deepseek/*), which was failing the Node 24 CI job at npm run format:check.
  • Stop the ESLint SARIF workflow from installing eslint@8.10.0 and pointing at a missing .eslintrc.js. It now uses Node 24, npm ci, the repo flat config, and only adds @microsoft/eslint-formatter-sarif.

Test plan

  • CI format:check passes
  • ESLint workflow install step no longer hits ERESOLVE

Prettier was failing on workflow YAML and the deepseek scratch files. The ESLint workflow pinned ESLint 8.10.0 and a missing .eslintrc.js, which conflicts with the flat ESLint 10 config.
@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@atherdon
atherdon merged commit 088eed3 into main Oct 3, 2026
6 checks passed
@atherdon
atherdon deleted the fix/ci-prettier-and-eslint branch October 3, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants