Repository navigation
refactor: split the renderer and install render-template - #19
Merged
Merged
Conversation
Install @llazyemail/render-template for RenderError and the shared error type. Move renderTemplate, the supporting public API, and the internal helpers into separate files without changing signatures or output.
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
src/runtime/render.tsheld the public renderer, the supporting API, and the internal helpers. The shared renderer now lives in@llazyemail/render-template.What
@llazyemail/render-templateat0.1.2. That tag runsprepare, so a git install buildsdistbefore packing.src/runtime/renderTemplate.tsis the publicrenderTemplatemethod. It validates, runs each part, collects a trace, calls compose, and returns aRenderResult.src/runtime/api.tsholdsdefineTemplate,renderMany,slot,hasSlot, andRenderError.src/runtime/helpers.tsholdsfinish,createContext,assertTemplate,assertPart,normalizeHtml,okTrace,skippedTrace,describeError, andpublish.src/runtime/render.tsre-exports the public API, so existing imports stay the same.Public signatures,
RenderError, and rendered output are unchanged.npm test(45) andnpm run typecheckpass.