Implement serde serialization and deserialization - #53
Open
mikwielgus wants to merge 1 commit into
Open
Conversation
mikwielgus
force-pushed
the
serde
branch
3 times, most recently
from
August 15, 2026 21:04
600ece5 to
03c6094
Compare
LPGhatguy
reviewed
Aug 17, 2026
LPGhatguy
left a comment
LPGhatguy
left a comment
Owner
There was a problem hiding this comment.
Looking solid! I've left only one comment here, the rest seems good to me.
mikwielgus
force-pushed
the
serde
branch
2 times, most recently
from
August 18, 2026 10:25
ab23b9c to
cb9804b
Compare
I also renamed `EmptySlot` to `VacantSlot` and `Slot::Empty` to `Slot::Vacant`, in line with established `OccupiedEntry` and `VacantEntry` terminology. Closes LPGhatguy#32
Contributor
Author
|
Just to be sure, are you waiting for me to resolve the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also renamed
EmptySlottoVacantSlotandSlot::EmptytoSlot::Vacant, in line with establishedOccupiedEntryandVacantEntryterminology.Closes #32