Skip to content

use a temp dir to do an atomic write for the raw file output #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jchiang87 merged 1 commit into from
Aug 28, 2026
Merged

use a temp dir to do an atomic write for the raw file output #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion imsim/readout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import tempfile
import numpy as np
import subprocess
import scipy
Expand Down Expand Up @@ -529,7 +530,13 @@ def prepare_hdus(self, rng):
def write_raw_file(hdus, file_name):
"""Write the raw data file."""
hdus[0].header['OUTFILE'] = os.path.basename(file_name)
hdus.writeto(file_name, overwrite=True)

# Use a temporary directory to do an atomic write.
dir_name = os.path.dirname(os.path.abspath(file_name))
with tempfile.TemporaryDirectory(dir=dir_name) as tmp_dir:
tmp_path = os.path.join(tmp_dir, "raw_file.fits.fz")
hdus.writeto(tmp_path)
os.replace(tmp_path, file_name)


class CameraReadout(ExtraOutputBuilder):
Expand Down
12 changes: 9 additions & 3 deletions tests/test_raw_file_writing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""
import os
from pathlib import Path
import logging
import unittest
from astropy.io import fits
import galsim
Expand Down Expand Up @@ -40,9 +41,11 @@ def test_raw_file_writing(self):
added_keywords = {'GAUSFWHM': 0.4,
'FOOBAR': 'hello, world'}

hdu = imsim.get_primary_hdu(eimage, "E2V-CCD250-382",
added_keywords=added_keywords)
hdr = hdu.header
logger = logging.getLogger()
ccd_readout = imsim.CcdReadout(eimage, logger, added_keywords=added_keywords)
rng = galsim.BaseDeviate()
hdus = ccd_readout.prepare_hdus(rng)
hdr = hdus[0].header

# Test some keywords.
self.assertAlmostEqual(hdr['RA'], eimage.header['RATEL'])
Expand All @@ -66,6 +69,9 @@ def test_raw_file_writing(self):
for key, value in added_keywords.items():
self.assertEqual(hdr[key], value)

# Write the file.
ccd_readout.write_raw_file(hdus, self.outfile)


if __name__ == '__main__':
unittest.main()
Loading