Kanban 2052: fetch the matching LIMS product manifest during TeamCity builds - #195
Open
labkey-willm wants to merge 1 commit into
Open
Kanban 2052: fetch the matching LIMS product manifest during TeamCity builds#195labkey-willm wants to merge 1 commit into
labkey-willm wants to merge 1 commit into
Conversation
… builds Only runs under TeamCity (this is a public repo) or with FETCH_LIMS_MANIFEST=1 for local testing, and no-ops for any LABKEY_DISTRIBUTION with no manifest published, since it lists the product's S3 prefix rather than assuming one exists. Overwrites startup/manifest.properties, which previously carried no real content (just the LABKEY_STARTUP_DISTRIBUTION_EXTRA envsubst placeholder).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The plan was always to pull the correct product manifest in during the container build (e.g. LabKey_267Release_Internal_FinalRelease_CloudInfrastructure_LimsStarterContainer), but that predates distributions#613 splitting one lims_starter manifest into several fine-grained product manifests, and the fetch itself was never actually implemented -
startup/manifest.propertieswas just the${LABKEY_STARTUP_DISTRIBUTION_EXTRA}envsubst placeholder with nothing setting it. Adds the fetch, generalized by LABKEY_DISTRIBUTION so both the existing lims_starter container build and a future lksm_professional sibling can use the same mechanism. This is a public repo, so the fetch only runs under LabKey's own TeamCity (or with an explicit local opt-in) - a community/external build has no access to, and no use for, the internal LIMS manifest bucket.Related Pull Requests
Changes
fetch-manifestMakefile target, made a prerequisite ofbuild, that lists the product's S3 prefix inlabkey-lims-manifestsand fetches whichever single manifest is there intostartup/manifest.propertiesTEAMCITY_VERSIONis set, or withFETCH_LIMS_MANIFEST=1for local testing - otherwise a no-opLABKEY_DISTRIBUTIONwith no manifest published (community, enterprise, allpg, etc.) - no allowlist needed