Kanban #2052: let embedded tomcat_lk.service respect a pre-set JAVA_HEAP - #81
Merged
Merged
Conversation
Packard's trial builders bake on a differently-sized box than they deploy to, so a heap computed from JAVA_HEAP_SIZE at install time doesn't fit the deploy box. This lets a caller override JAVA_HEAP directly (e.g. with a RAM-percentage flag); every existing caller is unaffected since none set it before.
labkey-jony
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Packard's trial-product AMI builds bake on a bigger box (m6a.large) than they deploy to (t3a.medium), and this script always overwrote JAVA_HEAP with a value computed from install-time memory - baking in a heap too large for the actual deploy box and crash-looping tomcat_lk on boot.
Related Pull Requests
Changes
step_tomcat_service_embeddednow respects a pre-set JAVA_HEAP instead of always overwriting it, so a caller can pass RAM-percentage flags sized correctly for whatever host actually boots. Every existing caller is unaffected since none set JAVA_HEAP before.