URLResolver: simplify URL mapping resolution - #2069
Open
labkey-nicka wants to merge 5 commits into
Open
Conversation
labkey-alan
approved these changes
Aug 31, 2026
| ); | ||
| } | ||
| // Callers pass a Query.Response, whose rows are Row instances and whose metadata field keys are | ||
| // FieldKey/SchemaKey instances. toJSON() flattens those to the plain strings that the field lookup and |
Contributor
There was a problem hiding this comment.
Suggested change
| // FieldKey/SchemaKey instances. toJSON() flattens those to the plain strings that the field lookup and | |
| // FieldKey/SchemaKey instances. JSON.stringify() flattens those to the plain strings that the field lookup and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Reduce and simplify processing of url's in select rows and search results.
Related Pull Requests
Changes
resolveSelectRowsandresolveSearchUsingIndexfrom Immutable to native objects and arraysincludesinstead ofindexOf_docIdurl parameter from every search hit url