Repository navigation
feat: the logarithmic sum bound [MDJKLV21, Lemma 9] with the constant 3 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmlexplore-automation
merged 2 commits into
LeanMachineLearning:main
from
RemyDegenne:roadmap/sum-div-max-one-log-essakine2026tight-reinforcementlearning
Nov 13, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 attribution — request_changes
claude/claude-opus-5-5The code credits [MDJKLV21, Lemma 9] and the Essakine2026Tight formalization, but leaves out [EV26, Lemma 28] and the erratum E19 behind the constant 3, both named in the description. The credit line for the adapted formalization is incomplete compared with the repo's own convention.
LMLExplore/Analysis/SpecialFunctions/Log/Basic.lean:446— The description says the source is [EV26, Lemma 28] and that the constant 3 follows erratum E19 in the project'snotes/paper-errata.md. Neither appears in the code, yet the sharpened constant is the main way this result differs from MDJKLV21. Fix: Cite [EV26, Lemma 28] and erratum E19 in the docstring ofsum_div_max_one_le_three_mul_log, and add an[EV26]entry to the module's References, using the same wording as inEpisodic/Basic.lean.LMLExplore/Analysis/SpecialFunctions/Log/Basic.lean:446— The credit for the adapted formalization says '(same author)', which is unverified and unclear, and it gives no licence, commit or full path. Fix: Follow the sibling files: give the full file pathEssakine2026Tight/ForLMLExplore/Analysis/SpecialFunctions/Log/Basic.lean, then 'by Rémy Degenne, Apache 2.0', and optionally the commit 9c77165d.Reply in this thread to contest a finding; that re-runs only this rubric and posts an answer here. (To fix it, just push a commit — that re-reviews on its own. To contest again after an answer, post a NEW reply rather than editing an old one.)
claude/claude-opus-5-5· 19s · 30.6k in (25k cache read, 5.6k cache write) / 1.7k out tokens · reviewing this diff · rubric