Repository navigation
feat: the eventual regret of ucbF as the Gaussian instance of KL-UCB #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RemyDegenne
wants to merge
2
commits into
LeanMachineLearning:main
Choose a base branch
from
RemyDegenne:roadmap/ucbf-gaussian-instance-worker1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−48
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 proof-quality — request_changes
claude/claude-opus-5-5The new pull-count proof duplicates two pieces of Gaussian reasoning already in
KLUCB.lean: the MGF dominance of each arm by the Gaussian family member, and the identityd(μ_a, μ*) = Δ_a² / (2σ²)from a rewrite chain. Both should become small lemmas shared with the existing proofs.LMLExplore/Bandits/KLUCB.lean:799— Thehdomblock (lines 799-802) repeats thehdomblock ofklucbFam_gaussianReal_regret_eventually_le(lines 775-778), differing only inm = 0and a commonσ2. This hides a reusable fact: a sub-Gaussian arm is MGF-dominated onunivby the matching member of the Gaussian family. Fix: Add a lemma, e.g.HasSubgaussianMGF.mgfDominatedOn_expFamily_natParam_gaussianReal (m) (hσ2) : MGFDominatedOn id μ id ((gaussianReal m σ2).expFamily id ((gaussianReal m σ2).natParam id μ[id])) univ, and use it in both proofs.LMLExplore/Bandits/KLUCB.lean:809—rwa [expFamilyDiv_gaussianReal _ hσ2, ← neg_sub, neg_sq, ← hgap, inv_div]is a five-step rewrite chain. Its first four steps redo the per-arm computation insidesum_gap_div_expFamilyDiv_gaussianReal(line 759:rw [expFamilyDiv_gaussianReal _ (hσ2 a), ← neg_sub, neg_sq, ← gap_eq_bestArm_sub]), so the identityd(μ_a, μ*) = Δ_a² / (2σ²)is stated nowhere and is rederived twice. Fix: Factor outexpFamilyDiv_gaussianReal_eq_gap_sq (m) (hσ2) : (gaussianReal m σ2).expFamilyDiv id (ν a)[id] (ν (bestArm ν))[id] = gap ν a ^ 2 / (2 * σ2). Use it in the sum lemma and here, which turns this step intorwa [expFamilyDiv_gaussianReal_eq_gap_sq, inv_div]and also removes the auxiliaryhgap.Reply in this thread to contest a finding; that re-runs only this rubric and posts an answer here. (To fix it, just push a commit — that re-reviews on its own. To contest again after an answer, post a NEW reply rather than editing an old one.)
claude/claude-opus-5-5· 26s · 64.1k in (51.1k cache read, 13k cache write) / 2.4k out tokens · reviewing this diff · rubric ·There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7636fcb, as suggested: added
HasSubgaussianMGF.mgfDominatedOn_expFamily_natParam_gaussianReal(for a generalX/Q, meanaand generatorm) andexpFamilyDiv_gaussianReal_eq_gap_sq. Bothhdomblocks are now one-liners using the first. The second replaces the rewrite chain insum_gap_div_expFamilyDiv_gaussianReal, and inUCBF.integral_pullCount_eventually_lethe last step is nowrwa [expFamilyDiv_gaussianReal_eq_gap_sq _ hσ2, inv_div], without the auxiliaryhgap.