Repository navigation
fix: skill templates referenced commands and fields 1.0 deleted - #58
Merged
Merged
Conversation
The 1.0 narrowing removed the scan, diff and context commands and the health score, but the three skill templates still told coding agents to use them. An agent running the shipped /architect-refactor reached a step marked CRITICAL telling it to read a health_score field nothing writes, warned in the same breath not to estimate the value. Every command the installed skills now name exists: the plan skill takes a baseline with `check . --baseline`, the refactor skill reads counts from `check . --json`, catchup reports with `check .`. Phase tracking counts violations rather than health, so state.json carries baseline_violations and latest_violations and ArchitectState matches. The duplication_pct comparison is replaced by god_files, which the phase snapshot really has. While confirming that, found `check . --baseline` never wrote .architect/scans/baseline.json - nothing had since 1.0 - so verify counted every pre-existing circular dependency as new and printed a failing line for it. The strict gate was unaffected because it guards on the snapshot existing, but the report was wrong. The baseline now records that snapshot, with a regression test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015e3bqn8QmG1H2fgHL15RoH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Levironexe
added a commit
that referenced
this pull request
Oct 23, 2026
fix: skill templates referenced commands and fields 1.0 deleted
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The 1.0 narrowing removed
scan,diffandcontextand the health score, but the three skill templates were never reconciled. Verified against@levironexe/architect@1.0.0from the registry, not a local build. A user who installs Architect today gets skill files containing:duplication_pctstate.jsonhealth fieldshealth_scorelatest_healthThe sharpest one is in
/architect-refactor, which tells the agent as a CRITICAL step to readhealth_scorefrom.architect/scans/phase-N.jsonand not to estimate it. That file's real fields aretimestamp, flagged_files, flagged_functions, circular_deps, total_files, total_loc, avg_file_loc, god_files. The plan skill also told the agent to runarchitect scan . --snapshot ...andarchitect context --techstack ..., neither of which exists.The fix
Every command the installed skills name now exists:
/architect-plantakes a baseline witharchitect check . --baselineand no longer calls a command to fetch the blueprint, becauseinitrenders the blueprint into the skill file. A wrong stack is corrected withinit --skill <id> --update./architect-refactorreads violation counts fromarchitect check . --json, and checksgod_filesfrom the phase snapshot instead of the nonexistentduplication_pct./architect-catchupreports witharchitect check ..state.jsoncarriesbaseline_violationsandlatest_violations, andArchitectStatematches.A second bug found on the way
check . --baselinenever wrote.architect/scans/baseline.json, and nothing else had written it since 1.0.verifytherefore treated every pre-existing circular dependency as newly introduced:The strict gate was unaffected, since it guards on the snapshot existing, but the printed report was wrong.
--baselinenow records the snapshot, and the same case reports(+0). Covered by a new regression test.Verified
Rendered the skills with the built CLI and grepped the output: zero dead references, zero unrendered template tokens, and every
architect ...invocation resolves to a real command and flag.npm run lint,npm run buildandnpm testall pass, 120 tests.Version bumped to 1.0.1.
🤖 Generated with Claude Code
https://claude.ai/code/session_015e3bqn8QmG1H2fgHL15RoH