Skip to content

ci: exclude the self-update version test that this fork inverts #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nana Mensa-Bonsu (kombonsu) merged 2 commits into from
Sep 23, 2026
Merged

ci: exclude the self-update version test that this fork inverts #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1248cbf
ci: exclude the self-update version test that this fork inverts
kombonsu Sep 23, 2026
40b8ec4
ci: say L0 compiles runnerversion, not only the image tag
kombonsu Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ jobs:

# Run tests
- name: L0
env:
# SelfUpdaterL0.TestSelfUpdateAsync_NoUpdateOnOldVersion asserts that a
# refresh to 2.200.0 is declined for being older than the running runner.
# This fork pins src/runnerversion to 0.0.1. publish-image.yml uses that
# file to tag the image, but this L0 job also compiles it: src/dev.sh
# passes it as RunnerVersion and src/dir.proj writes it into
# BuildConstants.RunnerPackage.Version, so 2.200.0 compares as newer and
# the test drives a real self-update download instead. Drop this filter
# once src/runnerversion tracks the RUNNER_VERSION in images/Dockerfile.
TestFilter: 'FullyQualifiedName!=GitHub.Runner.Common.Tests.Listener.SelfUpdaterL0.TestSelfUpdateAsync_NoUpdateOnOldVersion'
run: |
${{ matrix.devScript }} test
working-directory: src
Expand Down
5 changes: 4 additions & 1 deletion src/dir.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@
</Target>

<Target Name="Test" DependsOnTargets="GenerateConstant">
<PropertyGroup>
<TestFilterArg Condition="'$(TestFilter)' != ''">--filter %22$(TestFilter)%22</TestFilterArg>
</PropertyGroup>
<Exec Command="dotnet build Test/Test.csproj -c $(BUILDCONFIG) /p:PackageRuntime=$(PackageRuntime)" ConsoleToMSBuild="true" />
<Exec Command="dotnet test Test/Test.csproj -c $(BUILDCONFIG) --no-build --logger:trx" ConsoleToMSBuild="true" />
<Exec Command="dotnet test Test/Test.csproj -c $(BUILDCONFIG) --no-build --logger:trx $(TestFilterArg)" ConsoleToMSBuild="true" />
</Target>

<Target Name="Layout" DependsOnTargets="Clean;Build">
Expand Down
Loading