Repository navigation
[EPIC-U][LOU-HEALTH] No node:crypto import in toolRunContext; keep the Worker bundle loadable - #107
Merged
Merged
Conversation
…ker bundle loadable LOU-U15 (#99) imported randomUUID from node:crypto in src/execution/toolRunContext.ts, which workerd cannot load ('No such module "crypto"'), so the cloudflare 'wrangler dev serves the worker' test failed on main. Use the Worker-safe newId() helper (globalThis.crypto.randomUUID) instead; the generated id keeps the call_ prefix. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bY29ibQgv3MDdjAbUT4YR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the
node:cryptorandomUUIDimport insrc/execution/toolRunContext.tswith the Worker-safenewId()helper (globalThis.crypto.randomUUID). Generated ids keep thecall_prefix.Why
LOU-U15 (#99) introduced the import. workerd cannot load
node:crypto(No such module "crypto"), so the cloudflare adapter testwrangler dev serves the worker on the local workerd runtimefails on main and blockstest:coverage. Five open PRs reported the same failure.Acceptance criteria
src/execution/toolRunContext.tsimports nothing fromnode:*src/deploy/adapters/cloudflare.test.tspasses (15 tests)src/execution/toolRunContext.test.tspasses (8 tests)How verified
🤖 Generated with Claude Code
https://claude.ai/code/session_016bY29ibQgv3MDdjAbUT4YR
Generated by Claude Code