Repository navigation
V2: Warn when httpChannel has no verify; fix channel auth docs - #673
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
v2-httpchannel-verify-warn
branch
from
October 19, 2026 20:28
004b824 to
5f36617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit finding SEC-1 (Vercel competitor audit, 2026-10-19).
What was wrong
httpChannel()with noverifyis unauthenticated and keys sessions by the caller-chosensessionKey, so anyone reaching the port can read or continue another user's conversation. The docs quick start omittedverifyand listened on all interfaces; deployment.md claimed every route except/healthneeds the token.What changed
httpChannel()logs one[lousho]warning per instance, at creation, when noverifyis given (no throw).verify, binds to 127.0.0.1, new "Securing the http channel" section./chatand channels without their ownverify;/healthand self-authenticating channels are not gated (matches V1).Tests
New
src/channels/httpChannel.test.ts: warns exactly once withoutverify, never with it.npx tsc --noEmit,typecheck:tests,lintpass;vitest run src/channels docs322 pass. Full suite has 30 failing files from missing peer deps / tsup in this worktree's node_modules (providers, create-lousho-agent, kit tests) plus the known changelogGuard one, none touching channels.fallowcould not run: coverage file not produced because of those failures.verify-docs-snippets.tscould not build (tsup missing); the edited snippet isno-run.Behavior change: a one-time warning is logged for
httpChannel()withoutverify.Changelog: httpChannel() warns once when created without
verify; channel auth docs corrected.🤖 Generated with Claude Code