Repository navigation
V17: Drop the hardcoded fallback JWT secret from the auth docs - #678
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
v17-auth-docs-secret
branch
from
October 19, 2026 21:12
9460a82 to
31abf03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit finding SEC-10 (Vercel competitor audit, 2026-10-19).
What was wrong
docs/auth.md showed
jwt({ secret: process.env.JWT_SECRET ?? 'a-development-secret-of-32-bytes!!' })(plus?? 'ci-token',?? 'change-me'). Copy-pasted to production, an unset env var silently used a public secret.What changed
requireEnv()that throws at startup when unset; basic() examples useprocess.env.X!/ no fallback. The top snippet is markedno-run(it now needs env vars).jwt()already throws LOUSHO_AUTH_CONFIG_INVALID for an undefined or short secret andapiToken('')throws too; added test cases forsecret: undefinedandsecret: ''.?? ''placeholders (channels, triggers) are empty strings, not usable secrets, and were left alone.Tests
jwt.test.ts invalid-config table gains undefined and '' secrets (pass). Ran: tsc --noEmit, typecheck:tests, lint, docs:llms:check, verify-docs-snippets --source-only (333 snippets OK). grep for development-secret / ?? 'ci-token' / ?? 'change-me' in docs, README, examples, llms files is empty.
Changelog: Docs: auth examples no longer fall back to a hardcoded JWT secret when the env var is unset.
🤖 Generated with Claude Code