Skip to content

fix(observe): report successful spans as ok, not unknown #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinuxDevil merged 2 commits into from
Oct 24, 2026
Merged

fix(observe): report successful spans as ok, not unknown #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4687ded
fix(observe): report successful spans as ok, not unknown
LinuxDevil Oct 24, 2026
98e1601
test(observe): drop invalid 'unset' status literal from O5 test
LinuxDevil Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/observe/reporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,24 @@ describe('observeExporter', () => {
expect(allEvents(posted).at(-1)?.type).toBe('agent.deregister');
});

it('maps an ended span with unset status to ok', async () => {
const { r, posted } = reporter();
const span = makeSpan({ id: 'ended', endTime: 150 });
r.onSpanStart(span);
r.onSpanEnd(span);
await r.close();
expect(observations(posted).find((o) => o.data.obs_id === 'ended')?.data.status).toBe('ok');
});

it('keeps an open span status unset', async () => {
const { r, posted } = reporter();
const span = makeSpan({ id: 'open', endTime: undefined });
r.onSpanStart(span);
r.onSpanEnd(span);
await r.close();
expect(observations(posted).find((o) => o.data.obs_id === 'open')?.data.status).toBeUndefined();
});

it('carries usage/cost/flags verbatim from gen_ai + lousho attrs', async () => {
const { r, posted } = reporter();
const span = makeSpan({
Expand Down
6 changes: 4 additions & 2 deletions src/observe/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ const GENERIC_OUTPUT_KEYS = [GenAiAttr.OUTPUT_MESSAGES, LegacyAttr.RESULT] as co
function observationOf(span: Span, traceId: string, agentId: string, fallbackSessionId: string, now: () => number): ObservationData {
const attrs = span.attributes;
const op = str(attrs[GenAiAttr.OPERATION_NAME]) ?? '';
const status = span.status?.code;
const code = span.status?.code;
// An ended span nobody marked failed succeeded; only a still-open span stays unset.
const status = code === 'error' ? 'error' : span.endTime !== undefined ? 'ok' : undefined;
return {
obs_id: span.id,
trace_id: traceId,
Expand All @@ -165,7 +167,7 @@ function observationOf(span: Span, traceId: string, agentId: string, fallbackSes
name: span.name,
start: span.startTime,
end: span.endTime ?? now(),
...(status === 'ok' || status === 'error' ? { status } : {}),
...(status !== undefined ? { status } : {}),
...(pickAttr(attrs, INPUT_KEYS[op] ?? GENERIC_INPUT_KEYS) !== undefined
? { input: pickAttr(attrs, INPUT_KEYS[op] ?? GENERIC_INPUT_KEYS) }
: {}),
Expand Down
Loading