Repository navigation
fix(observe): O8 review - tests typecheck, explicit newlines, accurate stop docs - #708
Merged
Merged
Conversation
… serves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e stop docs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fallow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
obs/o8-per-db-pidfile
branch
from
October 24, 2026 14:24
93c6018 to
a6e901a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lousho observewrote oneobserve.pidper directory, so two daemons whose dbs shared a folder overwrote each other's pidfile andstop --db a.dbcould signal b's daemon (seen live). Pidfiles are now per db (observe.dbkeepsobserve.pid),/healthreports the db path,startrefuses a port serving another db, andstopchecks which db the pid's daemon serves before signalling.Ticket: O8 (Forge Observe vs LangSmith evaluation follow-up)
Changes
Verification: focused vitest,
tsc --noEmit, eslint on changed files (details in the review package); full suite and fallow run in CI.🤖 Generated with Claude Code