Repository navigation
test(studio): axe scans on every screen - #758
Merged
Merged
Conversation
…tton axe flagged it (aria-toggle-field-name, serious): a div with role="switch", no accessible name and no focus. Now a native button labelled "Enable OTel tracing", like the Inspector's hook switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a11y.spec.ts runs @axe-core/playwright (wcag2a + wcag2aa, devDependency pinned at 4.13.0) on every route in the new React-free route table (src/screens/routeTable.ts, each entry carries a concrete example path), plus the deep-link variants, the command palette and the shortcut sheet, failing on any serious/critical violation with rule id and targets. The single-<main>/h1/banner/nav checks stay. e2e/observeStub.ts fakes the observe daemon so the scans cover the populated states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rst load Hub fixtures (a fleet and a private entry in e2e-namespace) in observeStub.ts, the "sees stubbed data" check covers /hub and /hub/:namespace, beforeEach installs the stub before its first goto, and a note by SCANS says placeholder routes need fixtures when their screens land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real axe scans (owner-approved devDependency @axe-core/playwright 4.13.0) on every route in the shared route table plus the command palette and shortcut sheet, against a stubbed observe daemon; fixes the one serious violation found (unnamed OTel switch in Settings).
Ticket: F29 (Forge Observe vs LangSmith evaluation follow-up)
Changes
Verification: focused vitest,
tsc --noEmit, eslint on changed files (details in the review package); full suite and fallow run in CI.🤖 Generated with Claude Code