Repository navigation
[EPIC-D][LOU-D34] AgentType is optional and deprecated - #76
Merged
Merged
Conversation
AgentBuilder.build() no longer requires setType(); AgentConfig.agentType is optional. AgentType, setType() and the agent-types registry/validators are marked @deprecated (no runtime effect, removal in the next minor) and stay exported. createAgent() and specToAgent() no longer set a type. Registry text reduced to English one-liners. Docs snippets drop setType. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bY29ibQgv3MDdjAbUT4YR
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AgentBuilder.build()no longer requiressetType();AgentConfig.agentTypeis optional (key omitted when unset).AgentType,AgentTypeDescriptor,setType()and thesrc/agent-typesregistry/validators are marked@deprecated(no runtime effect, removal in the next minor). All stay exported.createAgent()andspecToAgent()(src/deploy/specExecution.ts) drop theirsetType(AgentType.SmartAssistant)call.validateAgentConfigonly checksagentTypewhen present (invalid values are still rejected).src/agent-types/registry.ts: Arabic/English prose reduced to plain English one-liners (Agent Forge does not use the registry).setType; api-overview marksAgentTypedeprecated; llms-full.txt regenerated.Why
Every builder user had to pick a meaningless donor-project type (AUDIT.md section 4). Epic D removes donor-project residue; this takes the type off the user path without breaking anyone.
Acceptance criteria
build()no longer requiressetType();agentTypeoptional; callers that only set it to satisfy validation stop doing soAgentType,setType(), registry/validators marked@deprecatedand still exported; registry text reduced to English one-linerssetTypeas required; llms files regeneratedHow verified
npx tsc --noEmit: passnpm run lint: 0 errors, 433 warnings (warning counts of touched files unchanged vs main)npm run test:types: 19 passed, no type errorsnpm run build && npm run build --workspace=packages/create-loushy-agent: passnpx vitest run: 137 files passed, 2022 tests passed, 3 skippednpm run docs:verify-snippets -- --skip-build: all 91 snippets type-checknpm run docs:llms:check: passnpm run test:coverage: exit 0;npm run fallow: exit 0, 0 above threshold🤖 Generated with Claude Code
https://claude.ai/code/session_016bY29ibQgv3MDdjAbUT4YR
Generated by Claude Code