Skip to content

fix(studio): bring TracesList under the fallow cognitive limit #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinuxDevil merged 1 commit into from
Oct 29, 2026
Merged

fix(studio): bring TracesList under the fallow cognitive limit #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions apps/agent-forge/src/screens/traces/TracesScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ function traceFacets(
];
}

const orUndefined = (v: string | undefined): string | undefined => v || undefined;
const rowsOf = (data: { traces: ObserveTraceRow[] } | undefined): ObserveTraceRow[] => data?.traces ?? [];
const totalOf = (data: { total: number } | undefined): number => data?.total ?? 0;
const agentsOf = (data: ObserveAgentRow[] | undefined): ObserveAgentRow[] => data ?? [];
const tableSort = (sort: TracesUrlState['sort']): TracesUrlState['sort'] => (sort && sort.key !== 'start' ? sort : undefined);

function TracesList() {
const route = useRoute();
const queryString = route.query.toString();
Expand All @@ -122,13 +128,13 @@ function TracesList() {
// Every filter edit restarts at the first page; replace keeps Back off the filter edits.
const update = (patch: Partial<TracesUrlState>) =>
navigate(`/traces${formatTracesQuery({ ...state, offset: 0, ...patch })}`, { replace: true });
const setText = (key: 'agent' | 'status' | 'model' | 'project' | 'q' | 'prompt') => (v: string | undefined) => update({ [key]: v || undefined });
const setText = (key: 'agent' | 'status' | 'model' | 'project' | 'q' | 'prompt') => (v: string | undefined) => update({ [key]: orUndefined(v) });

const range = useRangeFilter(state.window, '24h', (window) => update({ window }));
const onSort = (next: TableSort | undefined) => update({ sort: toSort(next) });

const rows = traces.data?.traces ?? [];
const facets = traceFacets(state, rows, agents.data ?? [], setText);
const rows = rowsOf(traces.data);
const facets = traceFacets(state, rows, agentsOf(agents.data), setText);
if (down) return <ObserveDaemonDown />;

return (
Expand All @@ -146,10 +152,10 @@ function TracesList() {
columns={columns(now)}
rows={rows}
rowKey={(t) => t.trace_id}
sort={state.sort && state.sort.key !== 'start' ? state.sort : undefined}
sort={tableSort(state.sort)}
onSortChange={onSort}
onRowOpen={(t) => navigate(`/traces/${encodeURIComponent(t.trace_id)}`)}
page={{ offset: state.offset, limit: PAGE_SIZE, total: traces.data?.total ?? 0, onChange: (offset) => update({ offset }) }}
page={{ offset: state.offset, limit: PAGE_SIZE, total: totalOf(traces.data), onChange: (offset) => update({ offset }) }}
loading={traces.loading}
empty={
<EmptyState
Expand Down
Loading