Repository navigation
U01: Token additions: status borders, fs-display, nav-bg, dock-width - #801
Merged
Merged
Conversation
…g, dock-width Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apps/agent-forge/src/theme.cssgains seven design tokens, each with its section comment and two-space indentation:--text-faint):--nav-bg: light-dark(#efeff2, #060608)— the nav rail and the frame behind the floating content card, one step darker than--bg.--violet-soft):--success-border,--warning-border,--danger-border,--info-border— eachcolor-mix(in srgb, var(--<status>) 40%, transparent)for the tinted-surface idiom (notices, toasts, change chips, tool rows).--dock-width: 490px— the docked right panel's default width.--fs-titleand--fs-metric):--fs-display: 22px— agent detail H1.src/__tests__/contrast.test.tsgains 12 pairs (24 generated cases):text/text-muted/text-faint/accentonnav-bg, andtext/text-mutedon each-softstatus tint.src/__tests__/polishCss.test.tsgains adescribe('U01 tokens')block asserting each token's exact declaration.No token is consumed yet; later tickets draw them (nav rail, docked panel, toasts, detail H1).
How it was tested
npm test --workspace apps/agent-forge -- --run src/__tests__— 94 tests passed (82 contrast incl. the 24 new cases, 12 polishCss)npm run typecheck,npm run typecheck:server,npm test -- --run(849 tests),npm run test:server(337 tests) — all pass inapps/agent-forgenpx tsc --noEmit,npm run lint— cleannpm run test:coverage— 6718 tests pass, coverage above thresholdsnpm run fallow— clean, 0 above thresholdAcceptance criteria
--nav-bgislight-dark(#efeff2, #060608)--{success,warning,danger,info}-borderiscolor-mix(in srgb, var(--<status>) 40%, transparent)--fs-display: 22pxand--dock-width: 490pxexist in:roottheme.css(nothing else changes)Generated with Devin