Repository navigation
fix(components): paint revealed sidebar row actions with the row's fill - #2986
Merged
Merged
Conversation
SidebarRowEndSlot reserves a 20px column per action so the ⋯ stays off the title, but revealed actions still drew with transparent pixels — the ⋯'s pressed/hover tint was a translucent background-color that would transmit anything beneath it. The slot now paints itself with the row's own fill while its actions are revealed (--sidebar-hover, or --sidebar-selection under aria-current), so every current and future end-slot action shares one opaque layer instead of relying on layout math alone. The ⋯'s tint moves to an inset shadow over that fill. Generated with [Devin](https://devin.ai) Model: swe-2-max Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Leeeon233
force-pushed
the
session-row-more-bg
branch
from
November 20, 2026 09:03
e5b7459 to
481d0d1
Compare
Leeeon233
marked this pull request as ready for review
November 20, 2026 09:07
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SidebarRowEndSlotnow paints itself with the row's own fill while its actions are revealed —--sidebar-hoveron hover/menu-open,--sidebar-selectionunderaria-current— so every current and future end-slot action (⋯, Archive, single-click actions) shares one opaque layer and nothing beneath it can ever show through..group:hover[aria-current=page]etc.) sincearia-currentandgroup/data-menu-openlive on the same row element; both unnamed and/rowgroup conventions are covered.bg-sidebar-foreground/15to an inset shadow over that fill — same shade, but it can no longer transmit content.SidebarRowEndSlotalready reserves a column per action (fix(components): reserve both columns for the sidebar row ⋯ and Archive #2984), which keeps the ⋯ off the title geometrically; this adds the complementary opaque backing so the no-bleed contract lives in the component rather than in layout math alone.Test plan
pnpm check— passed (typecheck + all suites)pnpm format— cleanpnpm run docs check— 0 errorsSessionList/LodySidebar: slot fill equals row fill — light hoverrgb(226,226,226), selectedrgb(214,214,214)witharia-current="page", dark hoverrgb(43,45,49), menu-open (data-menu-open)rgb(226,226,226); transparent at restrgba(28,28,28,0.15)inset shadow over the opaque fillGenerated with Devin