Skip to content

fix(components): paint revealed sidebar row actions with the row's fill - #2986

Merged
Leeeon233 merged 1 commit into
mainfrom
session-row-more-bg
Nov 20, 2026
Merged

Leeeon233 merged 1 commit into
mainfrom
session-row-more-bg

Conversation

@Leeeon233

@Leeeon233 Leeeon233 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • SidebarRowEndSlot now paints itself with the row's own fill while its actions are revealed — --sidebar-hover on hover/menu-open, --sidebar-selection under aria-current — so every current and future end-slot action (⋯, Archive, single-click actions) shares one opaque layer and nothing beneath it can ever show through.
  • Selection overrides compound the group state into one ancestor selector (.group:hover[aria-current=page] etc.) since aria-current and group/data-menu-open live on the same row element; both unnamed and /row group conventions are covered.
  • The ⋯'s pressed/hover ink tint moves from a translucent bg-sidebar-foreground/15 to an inset shadow over that fill — same shade, but it can no longer transmit content.
  • SidebarRowEndSlot already reserves a column per action (fix(components): reserve both columns for the sidebar row ⋯ and Archive #2984), which keeps the ⋯ off the title geometrically; this adds the complementary opaque backing so the no-bleed contract lives in the component rather than in layout math alone.
  • No copy added; ⋯ stays one 20px column left of Archive and both controls' behavior is unchanged.

Test plan

  • pnpm check — passed (typecheck + all suites)
  • pnpm format — clean
  • pnpm run docs check — 0 errors
  • Storybook probes on SessionList/LodySidebar: slot fill equals row fill — light hover rgb(226,226,226), selected rgb(214,214,214) with aria-current="page", dark hover rgb(43,45,49), menu-open (data-menu-open) rgb(226,226,226); transparent at rest
  • ⋯ pressed tint verified as rgba(28,28,28,0.15) inset shadow over the opaque fill
  • Long-title rows at 300px width: title clip ends before the action columns

Generated with Devin

SidebarRowEndSlot reserves a 20px column per action so the ⋯ stays off
the title, but revealed actions still drew with transparent pixels —
the ⋯'s pressed/hover tint was a translucent background-color that
would transmit anything beneath it. The slot now paints itself with
the row's own fill while its actions are revealed (--sidebar-hover, or
--sidebar-selection under aria-current), so every current and future
end-slot action shares one opaque layer instead of relying on layout
math alone. The ⋯'s tint moves to an inset shadow over that fill.

Generated with [Devin](https://devin.ai)

Model: swe-2-max

Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@Leeeon233 Leeeon233 changed the title fix(components): paint the sidebar row ⋯ trigger with the row's fill fix(components): paint revealed sidebar row actions with the row's fill Nov 20, 2026
@Leeeon233
Leeeon233 marked this pull request as ready for review November 20, 2026 09:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T09:08:40.908768Z 481d0d1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Leeeon233
Leeeon233 merged commit 2814492 into main Nov 20, 2026
14 checks passed
@Leeeon233
Leeeon233 deleted the session-row-more-bg branch November 20, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant