Repository navigation
fix(components): make per-model option scanning opt-in for Provider probes - #2990
Merged
Merged
Conversation
…robes Creating, testing, or retrying a Provider in AgentConfigDialog (and discovering Lody Agent connections) previously requested `readModelOptions: true` unconditionally via `useRefreshMachineAcpCapabilities`. For Providers with large model catalogs such as Devin (169 models), this blocked the modal on serial `session/set_config_option` switches for every model. Make `readModelOptions` opt-in (defaulting to false) in `useRefreshMachineAcpCapabilities`, pass `readModelOptions: true` only from explicit Provider refreshes in Settings > Agents (`ProviderRow`), remove the unused per-model progress state from `AgentConfigDialog`, update the architecture note, and add a regression test. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Model: gemini-4-neon-medium
…s test `activeWorkspaceRuntimeAtom` is derived from `runtimeAtom` and `currentWorkspaceIdAtom`, so seed `runtimeAtom` with matching `workspaceId` in the Jotai store for the regression test. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Model: gemini-4-neon-medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readModelOptionsopt-in (defaultfalse) inuseRefreshMachineAcpCapabilities, so Provider creation, testing, retrying inAgentConfigDialogand Lody Agent connection discovery run onlysession/newand do not block modals on serial per-modelsession/set_config_optionsweeps (such as Devin's 169-model catalog).readModelOptions: trueonly from explicit Provider refreshes in Settings > Agents (ProviderRow), keeping inline per-model option discovery and progress reporting intact.AgentConfigDialog.useRefreshMachineAcpCapabilitiesand update the EN/ZH architecture note (2026-11-11-observed-model-config-options).Test plan
NODE_ENV=test pnpm --filter @lody/components test tests/provider-row-reauthentication.test.tsx tests/agent-config-dialog.test.tsx tests/lody-agent-setting.test.tsx(59/59 passed)pnpm --filter @lody/components run typecheckpnpm lint&pnpm exec oxfmt --checkon all modified filesnode scripts/check-i18n.mjs,check-code-collab-imports,check-platform-boundaries,node scripts/docs/main.mjs checkGenerated with Devin