fix/SaveLastOpenFilesList()

[Pr0metheus2]

Fix for clearing "LastOpenFilesList" on app exit.
When app closes, it looks like it wipes the set of files to restore.

Before exit:

After exit:

Also fixes two other places (both places are affected by this fix and should now work correctly):

• Close other tabs (LogTabWindow.cs:2326)
• Session-save file list (LogTabWindow.cs:2410)

[Hirogen]

looks good, but pls change your indent style from tab to spaces.
Pls also add a unit test for this case [TabControllerTests.cs] should be the right class

Also change the inner for to an foreach, the for is not needed

[Pr0metheus2]

Ok

[Pr0metheus2]

The indexed loop for DisplayingContents should be kept; it exposes displayed entries through its custom Count and indexer, while foreach uses the inherited ReadOnlyCollection enumerator and does not return the displayed tabs. The prior LINQ implementation had this failure and caused an empty LastOpenFilesList at shutdown.

[Hirogen]

As a side note, pls also add to the pr description:
this fixes also 2 other places "Close other tabs" [LogTabWindow.cs:2326] and session-save file list [LogTabWindow.cs:2410], both places are affected by this fix and should now work correctly

[Pr0metheus2]

All should be fixed as required.

[Hirogen]

Sorry been on holidays, here is another review, only /t tabs, pls use spaces

LogExpert.Tests.csproj

• literal tab. +\t is tab-indented while the PackageReference line below it and every sibling use 4 spaces.

TabControllerTests.cs

• literal tab + whitespace-only line. The #region GetAllWindows Tests line is re-emitted as +\t#region GetAllWindows Tests, preceded by a new line containing only four spaces. Same editorconfig rules; the tab also breaks alignment with all 30+ other #region lines in the file.
• mixed indentation inside the initializer. In Setup() the two-line comment splits styles: // Match LogExpert's document style; … (spaces) then \t\t\t// Using DockingWindow both matches production behavior … (tabs). The second line is also ~180 chars where the first was wrapped.
• "CreateLogWindow can now provide a non-null LogWindow when needed" describes a capability the test never exercises; it explains the helper, not the assertion.
• #region Helpers is wedged between GetAllWindowsFromDockPanel Tests and GetAllWindows Tests, breaking the file's one-region-per-SUT-member ordering. Move helpers to the end.

TabController.cs

• misaligned comment. The two // Use 'for' instead of 'foreach': … lines sit at 8 spaces inside a 12-space foreach body, directly above the for they document.

[Hirogen]

see comment before

[Pr0metheus2]

Check please